Improve documentation for PostgreSQL predicate pushdown support #14036
Conversation
| @@ -459,6 +459,9 @@ The connector supports pushdown for a number of operations: | |||
| Predicate pushdown support | |||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| Predicates are pushed down for most types, including ``UUID`` and temporal | |||
| types, such as ``DATE`` and ``TIME``. | |||
There was a problem hiding this comment.
This reflects what @findepi mentioned in the slack communication and is good imho. Ideally we have a real list of supported data type or a statement like "for all types, besides xyz."
There was a problem hiding this comment.
TIME pushdown is not supported.
@sheajamba @mosabua
you should be able to validate soundness of docs with EXPLAIN over example tables.
At this point, the docs should already cover all the necessary steps to do so.
There was a problem hiding this comment.
Explicitly documenting which types are and are not supported is error prone and complex since pushdown depends on a lot of other factors as well.
We should instead teach users how to identify whether something was or wasn't pushed down by reading the EXPLAIN plan. It scales much better.
There was a problem hiding this comment.
Sure .. we have that to some degree in https://trino.io/docs/current/optimizer/pushdown.html and we should add more in https://trino.io/docs/current/optimizer/pushdown.html#predicate-pushdown
But .. we also need to add info that helps once a user finds that something is not pushed down .. then they have to be able to understand why .. is there some config problem, do have to do that.. or is it just not supported..
findepi
changed the title
|
Can we get this merged @hashhar ? |
sheajamba
force-pushed
the
postgresql-pushdown-docs
branch
from
8c407a2 to
acac3b8
Compare
Description
Non-technical explanation
Clarifies which data types are supported for Postgresql predicate pushdown.
Release notes
(x) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: