Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant keywords #14007

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

skrzypo987
Copy link
Member

Remove keywords that are implicit

Description

Is this change a fix, improvement, new feature, refactoring, or other?
refactoring I guess

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Sep 6, 2022
@raunaqmorarka raunaqmorarka merged commit 88f41de into trinodb:master Sep 6, 2022
@github-actions github-actions bot added this to the 395 milestone Sep 6, 2022
@@ -61,7 +61,7 @@ public OperatorFactory spillingJoin(
PartitioningSpillerFactory partitioningSpillerFactory,
BlockTypeOperators blockTypeOperators);

public static class JoinOperatorType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could checkstyle catch that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants