Support automatic type coercion for table creation #13994

mdesmet · 2022-09-05T21:49:13Z

Allow connectors to specify the actual Trino types that will be persisted and let the engine applies coercions as necessary.

Description

The behaviour around type coercion and casts in a CREATE TABLE is different from the CTAS. For example: the user created a table with TIMESTAMP(6). On insert the table type is compared to the query type and casts or coercions from the same type are applied upon the supplied values (resulting in rounding if necessary)

create table catalog.default.test (a TIMESTAMP(6));

insert into catalog.default.test values TIMESTAMP '9999-12-31 23:59:59.999999999';
-- no error

select a from catalog.default.test;
-- value is rounded

In this PR similar logic is applied upon CTAS statements through distinguishing between the target table type and the query type. By default the query and table type are the same, however a connector can specify overrides through a Connector Metadata method.

   /**
     * Coerces the input type to the effective Trino type supported by the connector
     * Return the effective {@link io.trino.spi.type.Type} that is supported by the connector for the given type, otherwise return {@link Optional#empty()}.
     */
    default Optional<Type> coerceNewTableColumn(ConnectorSession session, Type type)

Given this information coercions and casts can be performed by the engine instead of the connector itself, resulting in simpler connectors.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Change to core query engine and SPI

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# General
* Support automatic type coercion in engine for table creation.

losipiuk · 2022-09-12T09:24:05Z

@findepi, @martint I vaguely recall there was a discussion around this specific matter, not sure if conclusions were made. Is your memory more crispy?

hashhar · 2022-09-12T09:29:15Z

@losipiuk See #13981 (comment) - I guess that's what you are thinking of.

losipiuk · 2022-09-12T09:50:52Z

@losipiuk See #13981 (comment) - I guess that's what you are thinking of.

I meant something older - but this is a good summary. Thank you :)

losipiuk · 2022-09-12T09:59:03Z

core/trino-main/src/main/java/io/trino/sql/planner/LogicalPlanner.java


        String catalogName = destination.getCatalogName();
        CatalogHandle catalogHandle = metadata.getCatalogHandle(session, catalogName)
                .orElseThrow(() -> semanticException(CATALOG_NOT_FOUND, query, "Destination catalog '%s' does not exist", catalogName));
+
+        Assignments.Builder assignments = Assignments.builder();
+        ImmutableList.Builder<ColumnMetadata> insertedColumnsBuilder = ImmutableList.builder();


nit: createdColumnsBuilder/finalColumnsBuilder?

losipiuk · 2022-09-12T10:05:52Z

core/trino-main/src/main/java/io/trino/sql/planner/LogicalPlanner.java

@@ -530,6 +543,29 @@ private RelationPlan getInsertPlan(
                statisticsMetadata);
    }

+    private RelationPlan createPlanWithCoercions(RelationPlan plan, Assignments.Builder assignments, List<ColumnMetadata> insertedColumns)


nit: I would rather not pass builder but built assignemtns as arguemnt

core/trino-main/src/main/java/io/trino/sql/planner/LogicalPlanner.java

losipiuk · 2022-09-12T10:07:44Z

core/trino-main/src/main/java/io/trino/sql/planner/LogicalPlanner.java

+        ProjectNode projectNode = new ProjectNode(idAllocator.getNextId(), plan.getRoot(), assignments.build());
+        Scope scope = Scope.builder().withRelationType(RelationId.anonymous(), new RelationType(fields)).build();
+        plan = new RelationPlan(projectNode, scope, projectNode.getOutputSymbols(), Optional.empty());
+        return plan;


inline plan

losipiuk · 2022-09-12T10:10:13Z

core/trino-main/src/main/java/io/trino/type/TypeCoercion.java

@@ -92,6 +92,30 @@ public boolean isTypeOnlyCoercion(Type source, Type result)
            return sameDecimalSubtype && sameScale && sourcePrecisionIsLessOrEqualToResultPrecision;
        }

+        if (source instanceof TimestampWithTimeZoneType sourceTimestampWithTimeZone && result instanceof TimestampWithTimeZoneType targetTimestampWithTimeZone) {


nit: commit message Enable coercion for Time types -> Enable coercion for temporal types

Is the commit about "Enabling a coercion" or recognizing more coercions as "type-only"?

losipiuk · 2022-09-12T10:13:23Z

core/trino-main/src/main/java/io/trino/type/TypeCoercion.java

@@ -92,6 +92,30 @@ public boolean isTypeOnlyCoercion(Type source, Type result)
            return sameDecimalSubtype && sameScale && sourcePrecisionIsLessOrEqualToResultPrecision;
        }

+        if (source instanceof TimestampWithTimeZoneType sourceTimestampWithTimeZone && result instanceof TimestampWithTimeZoneType targetTimestampWithTimeZone) {
+            boolean sameTimestampWithTimeZoneType = sourceTimestampWithTimeZone.isShort() && targetTimestampWithTimeZone.isShort();


what if both are long?

Also what about just using:

boolean sameTimestampType = sourceTimestamp.isShort() == targetTimestamp.isShort();

losipiuk · 2022-09-12T10:16:00Z

core/trino-main/src/main/java/io/trino/type/TypeCoercion.java

+        if (source instanceof TimestampType sourceTimestamp && result instanceof TimestampType targetTimestamp) {
+            boolean sameTimestampType = (sourceTimestamp.isShort() && targetTimestamp.isShort())
+                    || (!sourceTimestamp.isShort() && !targetTimestamp.isShort());
+            boolean sourcePrecisionIsLessOrEqualToResultPrecision = sourceTimestamp.getPrecision() <= targetTimestamp.getPrecision();


targetMorePercise?
precisionNotLost?

losipiuk · 2022-09-12T10:18:25Z

core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java

+        CatalogHandle catalogHandle = catalogMetadata.getCatalogHandle(session, table);
+        ConnectorMetadata metadata = catalogMetadata.getMetadataFor(session, catalogHandle);
+        ConnectorSession connectorSession = session.toConnectorSession(catalogHandle);
+        return metadata.getNewTableMetadata(


should we check that number of columns returned by metadata.getNewTableMetadata matches columns from arguments?

findepi

I'd recommend spitting "Enable coercion for Time types" to a separate PR.
I hope it's orthogonal, but please correct me if i am wrong

findepi · 2022-09-17T18:39:42Z

core/trino-main/src/main/java/io/trino/type/TypeCoercion.java

+            return sameDecimalSubtype && sameScale && noPrecisionLoss;
+        }
+
+        if (source instanceof TimestampWithTimeZoneType sourceTimestampWithTimeZone && result instanceof TimestampWithTimeZoneType targetTimestampWithTimeZone) {


sourceTimestampWithTimeZone -> sourceType
targetTimestampWithTimeZone -> targetType

These long variables names do not add to readability

findepi · 2022-09-17T18:40:33Z

core/trino-main/src/main/java/io/trino/type/TypeCoercion.java

@@ -92,6 +92,30 @@ public boolean isTypeOnlyCoercion(Type source, Type result)
            return sameDecimalSubtype && sameScale && sourcePrecisionIsLessOrEqualToResultPrecision;
        }

+        if (source instanceof TimestampWithTimeZoneType sourceTimestampWithTimeZone && result instanceof TimestampWithTimeZoneType targetTimestampWithTimeZone) {


Is the commit about "Enabling a coercion" or recognizing more coercions as "type-only"?

findepi · 2022-09-17T18:40:45Z

core/trino-main/src/main/java/io/trino/type/TypeCoercion.java

+        }
+
+        if (source instanceof TimestampWithTimeZoneType sourceTimestampWithTimeZone && result instanceof TimestampWithTimeZoneType targetTimestampWithTimeZone) {
+            boolean sameTimestampWithTimeZoneType = sourceTimestampWithTimeZone.isShort() == targetTimestampWithTimeZone.isShort();


sameTimestampWithTimeZoneType -> sameRepresentation

findepi · 2022-09-17T18:43:53Z

core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java

+                columns,
+                properties,
+                comment);
+        checkState(newTableMetadata.getColumns().size() == columns.size(), "Table and query column count doesn't match");


What query is the message talking about?

I took this terminology from the INSERT vs table but maybe this is slightly flawed in the case of a CTAS.

So the query is the CTAS query, the table is the effective storage table.

core/trino-main/src/main/java/io/trino/sql/planner/LogicalPlanner.java

findepi · 2022-09-17T18:48:36Z

core/trino-main/src/main/java/io/trino/sql/planner/LogicalPlanner.java

+            if (queryType.equals(tableType) || typeCoercion.isTypeOnlyCoercion(queryType, tableType)) {
+                expression = fieldMapping.toSymbolReference();


It's not OK to omit type-only coercions in the plan.
The PlanNodes are strictly typed and all types must match.

The same code is there for INSERT. isn't the point of coercion that the types match?

findepi · 2022-09-17T18:49:42Z

core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java

@@ -446,6 +446,14 @@ default Optional<ConnectorTableLayout> getNewTableLayout(ConnectorSession sessio
        return Optional.empty();
    }

+    /**
+     * Get the physical metadata for a new table.


physical -> effective

Also, a method name could be changed to reflect that.
Maybe getNewTableEffectiveMetadata

findepi · 2022-09-17T18:53:04Z

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcClient.java

@@ -154,6 +154,11 @@ default void setTableProperties(ConnectorSession session, JdbcTableHandle handle
        throw new TrinoException(NOT_SUPPORTED, "This connector does not support setting table properties");
    }

+    default ConnectorTableMetadata getNewTableMetadata(ConnectorSession connectorSession, SchemaTableName schemaTableName, List<ColumnMetadata> columns, Map<String, Object> properties, Optional<String> comment)


JdbcClient interface should not need to operate on ConnectorTableMetadata. It should be granular, on per type basis.

Actually, we'd want to change or replace existing operation: io.trino.plugin.jdbc.JdbcClient#toWriteMapping.
The JdbcClient would want to return replacement Type that would go into the effective new table metadata.

mdesmet · 2022-09-18T21:26:08Z

I'd recommend spitting "Enable coercion for Time types" to a separate PR. I hope it's orthogonal, but please correct me if i am wrong

It is totally independent. I will move that to a separate PR.

kasiafi · 2022-10-03T09:34:32Z

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/WriteMapping.java

@@ -70,6 +87,11 @@ public WriteFunction getWriteFunction()
        return writeFunction;
    }

+    public WriteMapping withEffectiveType(Type effectiveType)


It seems that you can set the effectiveType arbitrarily, but it must be consistent with what toColumnMapping will return upon read.

We cannot verify that, because until we create the table, we don't have the input to feed into the toColumnMapping.

however, this also uncovers a problem with my earlier suggestion (#13994 (comment))
i suggested to change toWriteMapping, so that it can optionally return "effective type"
This is OK for callers like io.trino.plugin.jdbc.DefaultJdbcMetadata#getNewTableEffectiveMetadata and maybe for io.trino.plugin.jdbc.BaseJdbcClient#getColumnDefinitionSql.
But it's not OK for JdbcPageSink::JdbcPageSink -- the JdbcPageSink is too late to apply any "effective type".

Now as I am thinking about this, let's not put that into toWriteMapping method, but let's add a new method (that will be invoked from DefaultJdbcMetadata#getNewTableEffectiveMetadata for each column separately)

kasiafi · 2022-10-03T09:53:27Z

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

@@ -910,7 +910,7 @@ protected Scope visitCreateTableAsSelect(CreateTableAsSelect node, Optional<Scop
            }

            // create target table metadata
-            ConnectorTableMetadata tableMetadata = new ConnectorTableMetadata(targetTable.asSchemaTableName(), columns.build(), properties, node.getComment());
+            ConnectorTableMetadata tableMetadata = metadata.getNewTableEffectiveMetadata(session, catalogName, targetTable, columns.build(), properties, node.getComment());


We should analyze the old and new types pairwise and sanity-check if there exists the appropriate cast.

kasiafi · 2022-10-03T10:03:56Z

core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java

@@ -910,7 +910,7 @@ protected Scope visitCreateTableAsSelect(CreateTableAsSelect node, Optional<Scop
            }

            // create target table metadata
-            ConnectorTableMetadata tableMetadata = new ConnectorTableMetadata(targetTable.asSchemaTableName(), columns.build(), properties, node.getComment());
+            ConnectorTableMetadata tableMetadata = metadata.getNewTableEffectiveMetadata(session, catalogName, targetTable, columns.build(), properties, node.getComment());


Also, we must decide on the level of flexibility: I think the minimum plan would be to support implicit coercions only, but I'm not sure if it covers the targeted cases. And if we go beyond that minimum, do we want to fail on string truncation, etc.?
When we have the decision, then we need to verify if the new type returned by the connector satisfies our criteria.

The method typesMatchForInsert() can serve as a reference, but please note that it reflects (with some limitations) what the SQL standard says about inserts. The CTAS case is different, and it is not covered by the spec.

Also, we must decide on the level of flexibility: I think the minimum plan would be to support implicit coercions only, but I'm not sure if it covers the targeted cases.

Today, eg PostgreSQL (and co.) connector accepts any timestamp(n) and coerces it to timestamp(6).
This all happens inside the connector (in every such connector), and is an unnecessary complexity, since the coercion logic is effectively spread out.

For n <= 6 an implicit coercion would do, but for n > 6 we need to allow non-implicit coercions.

findepi · 2022-10-03T11:07:41Z

core/trino-main/src/main/java/io/trino/metadata/Metadata.java

+    /**
+     * Returns the table metadata with the effective Trino types specific for the connector
+     */
+    ConnectorTableMetadata getNewTableEffectiveMetadata(Session session, String catalogName, QualifiedObjectName tableName, List<ColumnMetadata> columns, Map<String, Object> properties, Optional<String> comment);


That's meant to be used (and is used) only for CTAS and not for regular CT.
The method name should reflect that.

cc @martint for any naming suggestion

getConnectorTableMetadataForCTAS
getEffectiveConnectorTableMetadataForCTAS
getConnectorTableMetadataForCreateTableAsSelect
getCreateTableAsSelectConnectorTableMetadata

Out of those my preference would be getConnectorTableMetadataForCreateTableAsSelect.

WDYT?

What is the point of passing properties and comment?

Or can we introduce a API which could take in a Type and provide a supported Type as Output ?

findepi · 2022-10-03T11:08:38Z

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/WriteMapping.java

@@ -70,6 +87,11 @@ public WriteFunction getWriteFunction()
        return writeFunction;
    }

+    public WriteMapping withEffectiveType(Type effectiveType)


We cannot verify that, because until we create the table, we don't have the input to feed into the toColumnMapping.

however, this also uncovers a problem with my earlier suggestion (#13994 (comment))
i suggested to change toWriteMapping, so that it can optionally return "effective type"
This is OK for callers like io.trino.plugin.jdbc.DefaultJdbcMetadata#getNewTableEffectiveMetadata and maybe for io.trino.plugin.jdbc.BaseJdbcClient#getColumnDefinitionSql.
But it's not OK for JdbcPageSink::JdbcPageSink -- the JdbcPageSink is too late to apply any "effective type".

Now as I am thinking about this, let's not put that into toWriteMapping method, but let's add a new method (that will be invoked from DefaultJdbcMetadata#getNewTableEffectiveMetadata for each column separately)

mdesmet · 2022-10-27T06:36:13Z

@kasiafi, @findepi : PTAL

Outside of the method name change I've addressed all other comments.

mdesmet · 2023-01-02T14:10:10Z

@ebyhr: Can you have a look at this?

ebyhr · 2023-01-13T10:22:06Z

Sorry for my late response. Let me take a look when I have the time.

...n/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlConnectorTest.java

core/trino-main/src/main/java/io/trino/execution/CreateTableTask.java

...n/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlConnectorTest.java

core/trino-main/src/test/java/io/trino/execution/TestCreateTableColumnTypeCoercion.java

core/trino-main/src/test/java/io/trino/execution/TestCreateTableTask.java

core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java

core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java

martint · 2023-08-17T22:43:30Z

core/trino-main/src/main/java/io/trino/sql/planner/LogicalPlanner.java

+        forEachPair(tableMetadata.getColumns().stream(), visibleFieldMappings.stream(), (column, fieldMapping) -> {
+            Expression expression;
+            Type tableType = column.getType();
+            Type queryType = symbolAllocator.getTypes().get(fieldMapping);
+            if (queryType.equals(tableType) || typeCoercion.isTypeOnlyCoercion(queryType, tableType)) {
+                expression = fieldMapping.toSymbolReference();
+            }
+            else {
+                expression = noTruncationCast(fieldMapping.toSymbolReference(), queryType, tableType);
+            }
+            Symbol output = symbolAllocator.newSymbol(column.getName(), column.getType());
+            assignments.put(output, expression);
+            finalColumnsBuilder.add(column);
+        });


I don't believe this comment has been addressed.

...n/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlConnectorTest.java

core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java

mdesmet · 2023-09-03T18:28:43Z

@martint : As discussed offline, PTAL.

findinpath · 2023-09-04T04:58:04Z

There are a few unrelated failures on the build on elasticsearch and kafka connectors.
Consider pushing an empty commit to rebuild.

Praveen2112 · 2023-09-04T09:37:08Z

@mdesmet Thanks for working on this. Can you update the release notes and we could merge this PR.

mdesmet · 2023-09-04T10:45:54Z

@Praveen2112 : I have updated the issue description. PTAL.

Praveen2112 · 2023-09-04T13:20:04Z

Thanks for working on this !!

kokosing · 2023-09-04T13:27:09Z

Well done! Thank you all involved! 🎉

cla-bot bot added the cla-signed label Sep 5, 2022

mdesmet requested review from findepi and losipiuk September 5, 2022 21:49

mdesmet mentioned this pull request Sep 5, 2022

Support automatic type coercion in Iceberg table creation #13981

Merged

losipiuk reviewed Sep 12, 2022

View reviewed changes

core/trino-main/src/main/java/io/trino/sql/planner/LogicalPlanner.java Outdated Show resolved Hide resolved

losipiuk reviewed Sep 12, 2022

View reviewed changes

losipiuk requested a review from kasiafi September 12, 2022 10:19

mdesmet force-pushed the feature/ctas_table_type branch from 7e76ee9 to b7a2a61 Compare September 12, 2022 20:23

findepi reviewed Sep 17, 2022

View reviewed changes

mdesmet force-pushed the feature/ctas_table_type branch from b7a2a61 to c1a653b Compare October 2, 2022 17:56

kasiafi reviewed Oct 3, 2022

View reviewed changes

findepi reviewed Oct 3, 2022

View reviewed changes

mdesmet force-pushed the feature/ctas_table_type branch from c1a653b to 266ef0c Compare October 26, 2022 21:09

mdesmet requested a review from martint November 9, 2022 15:23

mdesmet requested a review from ebyhr January 2, 2023 13:35

findepi mentioned this pull request Jan 19, 2023

Support CREATE TABLE AS with timestamp columns of non-default precision in Hive #6436

Open

mdesmet force-pushed the feature/ctas_table_type branch from fc16a30 to 5984f4e Compare July 23, 2023 21:50

mdesmet added 2 commits July 27, 2023 09:35

Remove redundant list creation

62b5458

Use visibleFields helper method

7e05ac6

mdesmet force-pushed the feature/ctas_table_type branch from 5984f4e to 42dcd1e Compare July 27, 2023 07:36

Praveen2112 reviewed Jul 27, 2023

View reviewed changes

mdesmet mentioned this pull request Jul 29, 2023

Remove docs about overriding current_timestamp type when Trino's iceberg implementation supports TIMESTAMP(3) starburstdata/dbt-trino#126

Open

1 task

mdesmet force-pushed the feature/ctas_table_type branch from 42dcd1e to e20e6d7 Compare August 3, 2023 21:15

kokosing approved these changes Aug 16, 2023

View reviewed changes

Praveen2112 approved these changes Aug 17, 2023

View reviewed changes

martint requested changes Aug 17, 2023

View reviewed changes

mdesmet force-pushed the feature/ctas_table_type branch from e20e6d7 to 1b42df9 Compare August 24, 2023 12:09

marcinsbd mentioned this pull request Aug 25, 2023

Coerce column type varchar0 to varchar1 for hive table #18811

Merged

findinpath self-requested a review September 1, 2023 06:57

findinpath reviewed Sep 1, 2023

View reviewed changes

...n/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlConnectorTest.java Show resolved Hide resolved

findinpath reviewed Sep 1, 2023

View reviewed changes

core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java Outdated Show resolved Hide resolved

mdesmet added 3 commits September 3, 2023 20:27

Allow connector to automatically coerce type during table creation

cc3a45a

Allow jdbc connector to automatically coerce type during table creation

fd53048

Allow postgresql connector to coerce type during table creation

9559aac

mdesmet force-pushed the feature/ctas_table_type branch from 1b42df9 to 9559aac Compare September 3, 2023 18:27

martint approved these changes Sep 3, 2023

View reviewed changes

Praveen2112 merged commit d904a6a into trinodb:master Sep 4, 2023

github-actions bot added this to the 426 milestone Sep 4, 2023

colebow mentioned this pull request Sep 5, 2023

Add Trino 426 release notes #18867

Merged

davseitsev mentioned this pull request Apr 11, 2024

Automatic type coercion doesn't work for structural types #21511

Closed

		if (queryType.equals(tableType) \|\| typeCoercion.isTypeOnlyCoercion(queryType, tableType)) {
		expression = fieldMapping.toSymbolReference();

Support automatic type coercion for table creation #13994

Support automatic type coercion for table creation #13994

Conversation

mdesmet commented Sep 5, 2022 • edited Loading

Description

Documentation

Release notes

losipiuk commented Sep 12, 2022

hashhar commented Sep 12, 2022

losipiuk commented Sep 12, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

losipiuk Sep 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

findepi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdesmet commented Sep 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mdesmet commented Oct 27, 2022

mdesmet commented Jan 2, 2023

ebyhr commented Jan 13, 2023 • edited Loading

Choose a reason for hiding this comment

mdesmet commented Sep 3, 2023

findinpath commented Sep 4, 2023 • edited Loading

Praveen2112 commented Sep 4, 2023

mdesmet commented Sep 4, 2023

Praveen2112 commented Sep 4, 2023

kokosing commented Sep 4, 2023

mdesmet commented Sep 5, 2022 •

edited

Loading

losipiuk Sep 12, 2022 •

edited

Loading

ebyhr commented Jan 13, 2023 •

edited

Loading

findinpath commented Sep 4, 2023 •

edited

Loading