Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate interval literal tests to new assertions #13977

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

martint
Copy link
Member

@martint martint commented Sep 2, 2022

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Sep 2, 2022
@martint martint changed the title Migrate interval tests to new assertions Migrate interval literal tests to new assertions Sep 2, 2022
@martint martint requested a review from dain September 3, 2022 16:01
@martint martint force-pushed the interval-literal-test branch from 0c03a8f to 9e40449 Compare September 6, 2022 16:59
Copy link
Member

@dain dain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future conversions, please splitup/move the tests in one commit and the convert in another commit.

@martint martint merged commit 0f74f69 into trinodb:master Sep 7, 2022
@martint martint deleted the interval-literal-test branch September 7, 2022 03:13
@github-actions github-actions bot added this to the 395 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants