Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete TODO comment in BaseConnectorTest.testCommentColumn #13883

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Aug 27, 2022

Description

Remove obsolete TODO comment in BaseConnectorTest.testCommentColumn

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

testCreateTableWithColumnComment already covers the test case.
@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Aug 27, 2022
@cla-bot cla-bot bot added the cla-signed label Aug 27, 2022
@ebyhr
Copy link
Member Author

ebyhr commented Aug 28, 2022

CI hit #13887

@ebyhr ebyhr requested review from wendigo and hashhar August 29, 2022 00:12
@ebyhr ebyhr merged commit 441889c into trinodb:master Aug 30, 2022
@ebyhr ebyhr deleted the ebi/test-create-table-comment branch August 30, 2022 01:55
@github-actions github-actions bot added this to the 395 milestone Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

3 participants