Fix trino-tests timeout #13618
Merged
Fix trino-tests timeout #13618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
requested review from
nineinchnick,
losipiuk,
arhimondr,
ebyhr and
hashhar
nineinchnick
approved these changes
Aug 11, 2022
Praveen2112
approved these changes
Aug 11, 2022
findepi
force-pushed
the
findepi/fix-trino-tests-timeout
branch
from
d917476 to
288239a
Compare
|
I moved |
hashhar
approved these changes
Aug 11, 2022
`trino-faulttolerant-tests` is the module for fault-tolerant tests, so move `TestDistributedFaultTolerantEngineOnlyQueries` and `TestFaultTolerantExecutionDynamicFiltering` from `trino-tests` there. This also isolates these test classes when executing on CI. It was seen that `trino-tests` often times out on the CI, apparently because of `TestDistributedFaultTolerantEngineOnlyQueries`, leading to `trino-tests` tests results being not available.
findepi
force-pushed
the
findepi/fix-trino-tests-timeout
branch
from
288239a to
6fb478f
Compare
arhimondr
approved these changes
Aug 11, 2022
|
Thanks @findepi |
ebyhr
approved these changes
Aug 11, 2022
|
CI #13638, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.