-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trino 392 release notes #13342
Add Trino 392 release notes #13342
Conversation
0ed0296
to
5943414
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with current status .. date will have to change though
516b96c
to
6fce87c
Compare
configuration property as a replacement for | ||
``assumeLiteralNamesInMetadataCallsForNonConformingClients``, which is | ||
deprecated and planned to be removed in a future release. ({issue}`12761`) | ||
* Add report for total time elapsed reading data from JDBC sources. ({issue}`13132`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a report in the JDBC driver? sounds weird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other option was to include it on all the JDBC connectors, I'll move it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Trino JDBC driver is entirely unrelated to connectors like MySQL, PostgreSQL, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current section is wrong. Please move to each JDBC connectors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be copied and be in each specific connector.. we abandoned the JDBC connectors section usage since its is not clear to the user what these are .. nor is it always consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Language feels weird. Would Report the total time spent reading data from the source
(in EXPLAIN ANALYZE VERBOSE, the web UI and event listeners)?
Add report
feels like there in some actual report I can look at.
The part in brackets I consider to be too much information but others may think differently.
* Prevent writing to a table with `NOT NULL` or | ||
[invariants](https://github.com/delta-io/delta/blob/master/PROTOCOL.md#column-invariants) | ||
columns. ({issue}`12635`) | ||
* Fix incorrect min and max statistics when writing `NULL`. ({issue}`13389`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
table statistics ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or table statistic values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
column statistics
|
||
## Pinot connector | ||
|
||
* Redact the values of `pinot.grpc.tls.keystore-password` and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use "Hide" or "Obfuscate" instead .. what did we do in the past?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used "Redact" in the past release notes. I don't see the usage of "Hide" or "Obfuscate".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok .. keep that then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches the previous language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colebow Why did you change to "Obfuscate"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The follow-up conversation didn't show up for me for some reason. Looks like Martin caught it
configuration property as a replacement for | ||
``assumeLiteralNamesInMetadataCallsForNonConformingClients``, which is | ||
deprecated and planned to be removed in a future release. ({issue}`12761`) | ||
* Add report for total time elapsed reading data from JDBC sources. ({issue}`13132`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Trino JDBC driver is entirely unrelated to connectors like MySQL, PostgreSQL, etc.
* Prevent writing to a table with `NOT NULL` or | ||
[invariants](https://github.com/delta-io/delta/blob/master/PROTOCOL.md#column-invariants) | ||
columns. ({issue}`12635`) | ||
* Fix incorrect min and max statistics when writing `NULL`. ({issue}`13389`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
column statistics
|
||
## Pinot connector | ||
|
||
* Redact the values of `pinot.grpc.tls.keystore-password` and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches the previous language
Merged as d92b366 |
* Add report for total time elapsed reading data from JDBC sources. ({issue}`13132`) | ||
* Change mapping for the MySQL `enum` type to the Trino `varchar` type instead | ||
of the `char` type. ({issue}`13303`) | ||
* Fix failure when reading table statistics while the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the visible symptom - not the cause. User facing RN should probably say Make reading table statistics more resilient across MySQL versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I'm a bit late. No problem. 😄 I'll try to be more proactive about reviewing these.
## PostgreSQL connector | ||
|
||
* Add report for total time elapsed reading data from JDBC sources. ({issue}`13132`) | ||
* Improve performance of queries with an `IN` expression within a complex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve performance of queries involving
IN expression by pushing predicate computation to the PostgreSQL database.
.
It affects IN
generally not IN
within a "complex expression". "Complex expression pushdown" is just the term we use when talking about pushing down "complex" things.
Description
Assemble the release notes for the upcoming Trino 392 release.
Improvement
Docs only.
Add the release notes for Trino 392 with sections for general, security, connectors and other topics as included in the release.
Related issues, pull requests, and links
Fixes #13320
Documentation
( ) No documentation is needed.
(✅) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(✅) No release notes entries required.
( ) Release notes entries required with the following suggested text:
Verification for each commit
Format: commit, committer/maintainer, PR/issue number, ✅ / ❌ rn ✅ / ❌ docs
✅ rn - release note added and verified, or assessed to be not necessary, set to ❌ rn before completion
✅ docs - need for docs assessed and merged, or assessed to be not necessary, set to ❌ docs before completion
22 July 2022 ✅
958b18d @dain #13274 ✅ rn ✅ docs
d414f56 @dain #13274 ✅ rn ✅ docs
b370bf8 @dain #13274 ✅ rn ✅ docs
ff323dc @dain #12990 ✅ rn ✅ docs
6014c58 @dain #12990 ✅ rn ✅ docs
4520fd3 @dain #12990 ✅ rn ✅ docs
44e6917 @dain #12990 ✅ rn ✅ docs
37b9ae8 @dain #12990 ✅ rn ✅ docs
47178c1 @dain #12990 ✅ rn ✅ docs
8381a9d @dain #12990 ✅ rn ✅ docs
23 July 2022 ✅
d7ce89a @ebyhr #13179 ✅ rn ✅ docs
7f5034c @ebyhr #13300 ✅ rn ✅ docs
185bb6e @ebyhr #13300 ✅ rn ✅ docs
b60f388 @raunaqmorarka #13248 ✅ rn ✅ docs
fd82ae5 @ebyhr #13237 ✅ rn ✅ docs
1e7d89c @dain #13321 ✅ rn ✅ docs
25 July 2022 ✅
382badb @ebyhr #13323 ✅ rn ✅ docs
fa527e9 @ebyhr #13304 ✅ rn ✅ docs
db27852 @sopel39 #13315 ✅ rn ✅ docs
ed34eb7 @sopel39 #13330 ✅ rn ✅ docs
079fe43 @findepi #13291 ✅ rn ✅ docs
85d2946 @sopel39 #13333 ✅ rn ✅ docs
e32ed00 @sopel39 #13178 ✅ rn ✅ docs
5662d3d @sopel39 #13178 ✅ rn ✅ docs
c85ef9d @sopel39 #13178 ✅ rn ✅ docs
71c3940 @sopel39 #13178 ✅ rn ✅ docs
713cce7 @sopel39 #13178 ✅ rn ✅ docs
717ad18 @sopel39 #13178 ✅ rn ✅ docs
165c582 @sopel39 #13178 ✅ rn ✅ docs
2fe72d5 @sopel39 #13178 ✅ rn ✅ docs
92a8586 @sopel39 #13339 ✅ rn ✅ docs
5438d7d @ebyhr #12125 ✅ rn ✅ docs
2c7db33 @ebyhr #13020 ✅ rn ✅ docs
4c470ae @ebyhr #13120 ✅ rn ✅ docs
7771910 @electrum #13324 ✅ rn ✅ docs
1a2d285 @electrum #13324 ✅ rn ✅ docs
b646676 @electrum #13329 ✅ rn ✅ docs
26 July 2022 ✅
aa551d8 @electrum #13219 ✅ rn ✅ docs
bb1a57f @electrum #13219 ✅ rn ✅ docs
2aec276 @sopel39 #13351 ✅ rn ✅ docs
f343f26 @sopel39 #13340 ✅ rn ✅ docs
662de67 @sopel39 #13340 ✅ rn ✅ docs
27 July 2022 ✅
4174ea9 @dain #13370 ✅ rn ✅ docs
f99ca9c @ebyhr #13082 ✅ rn ✅ docs
e7e4dd1 @raunaqmorarka #13001 ✅ rn ✅ docs
de86723 @raunaqmorarka #13001 ✅ rn ✅ docs
698604c @raunaqmorarka #13193 ✅ rn ✅ docs
e31694c @raunaqmorarka #13193 ✅ rn ✅ docs
45ea2a5 @Praveen2112 #13260 ✅ rn ✅ docs
acd614d @raunaqmorarka #13046 ✅ rn ✅ docs
2265ca8 @raunaqmorarka #13046 ✅ rn ✅ docs
49ff2e1 @martint #13376 ✅ rn ✅ docs
1a6ab5a @findepi #13247 ✅ rn ✅ docs
84ec191 @findepi #13378 ✅ rn ✅ docs
203a2e7 @raunaqmorarka #12152 ✅ rn ✅ docs
5ea4b2f @raunaqmorarka #12152 ✅ rn ✅ docs
e831b2f @raunaqmorarka #12152 ✅ rn ✅ docs
d382520 @raunaqmorarka #12152 ✅ rn ✅ docs
503a0aa @raunaqmorarka #12152 ✅ rn ✅ docs
b3038d9 @raunaqmorarka #12152 ✅ rn ✅ docs
0729d78 @ebyhr #13316 ✅ rn ✅ docs
fa559d0 @ebyhr #13368 ✅ rn ✅ docs
627e395 @hashhar #11261 ✅ rn ✅ docs
28 July 2022 ✅
ba497dd @ebyhr #13118 ✅ rn ✅ docs
b39ac7c @ebyhr #13353 ✅ rn ✅ docs
82a2cb6 @ebyhr #13397 ✅ rn ✅ docs
e210738 @ebyhr #13343 ✅ rn ✅ docs
fa145ca @Praveen2112 #13335 ✅ rn ✅ docs
a55cabe @Praveen2112 #13335 ✅ rn ✅ docs
433d799 @Praveen2112 #13335 ✅ rn ✅ docs
6cfefd2 @Praveen2112 #13335 ✅ rn ✅ docs
9e4e8c7 @Praveen2112 #13335 ✅ rn ✅ docs
81a84e6 @Praveen2112 #13335 ✅ rn ✅ docs
f1122d3 @Praveen2112 #13335 ✅ rn ✅ docs
29 July 2022
2c5ce56 @findepi #13136 ✅ rn ✅ docs
1182705 @findepi #13136 ✅ rn ✅ docs
c129b38 @findepi #13136 ✅ rn ✅ docs
6e217f5 @ebyhr #13403 ✅ rn ✅ docs
0243414 @ebyhr #13403 ✅ rn ✅ docs
84f40a4 @ebyhr #13403 ✅ rn ✅ docs
911c055 @ebyhr #13404 ✅ rn ✅ docs
a5b35ee @findepi #13411 ✅ rn ✅ docs
0241eba @findepi #9447 ✅ rn ✅ docs
404c188 @findepi #9447 ✅ rn ✅ docs
f1d47c3 @findepi #9447 ✅ rn ✅ docs
e9d83cf @electrum #13121 ✅ rn ✅ docs
461c46c @electrum #13066 ✅ rn ✅ docs
2b26212 @electrum #12247 ✅ rn ✅ docs
bedbcf6 @electrum #13399 ✅ rn ✅ docs
4c6ac60 @sopel39 #13415 ✅ rn ✅ docs
ef39dcd @sopel39 #13415 ✅ rn ✅ docs
96b9a35 @sopel39 #13415 ✅ rn ✅ docs
30 July 2022 ✅
e6570a6 @Praveen2112 #13412 ✅ rn ✅ docs
1618bb1 @Praveen2112 #13412 ✅ rn ✅ docs
1 August 2022 ✅
8689f5c @sopel39 #13420 ✅ rn ✅ docs
1f379a3 @findepi #13090 ✅ rn ✅ docs
899f9a8 @nineinchnick #13364 ✅ rn ✅ docs
49d8e11 @findepi #13239 ✅ rn ✅ docs
fbdbefc @findepi #12941 ✅ rn ✅ docs
2785cf0 @findepi #13356 ✅ rn ✅ docs
b97e7fa @arhimondr #13354 ✅ rn ✅ docs
2a74545 @ebyhr #13422 ✅ rn ✅ docs
8076203 @ebyhr #13422 ✅ rn ✅ docs
60f7017 @ebyhr #13440 ✅ rn ✅ docs
890cb54 @ebyhr #13438 ✅ rn ✅ docs
737b614 @raunaqmorarka #13132 ✅ rn ✅ docs
2 August 2022 ✅
bbe9d4a @findepi #12786 ✅ rn ✅ docs
b8b9a39 @findepi #12786 ✅ rn ✅ docs
ee3fd2f @findepi #12786 ✅ rn ✅ docs
0eb0efe @ebyhr #13443 ✅ rn ✅ docs
02f1d8d @ebyhr #13430 ✅ rn ✅ docs
080216f @ebyhr #13455 ✅ rn ✅ docs
da44a6d @findepi #13425 ✅ rn ✅ docs
933f698 @electrum #12159 ✅ rn ✅ docs
7c99ee1 @findepi #13285 ✅ rn ✅ docs
99aa7dd @ebyhr #13012 ✅ rn ✅ docs
3405143 @ebyhr #13012 ✅ rn ✅ docs
44555a0 @ebyhr #13418 ✅ rn ✅ docs
5980cf7 @ebyhr #13471 ✅ rn ✅ docs