-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reading BYTE_STREAM_SPLIT encoding in parquet #12809
Support reading BYTE_STREAM_SPLIT encoding in parquet #12809
Conversation
lib/trino-parquet/src/test/java/io/trino/parquet/reader/TestColumnReader.java
Outdated
Show resolved
Hide resolved
75646e6
to
9c4b277
Compare
1af0a48
to
bea52a6
Compare
lib/trino-parquet/src/main/java/io/trino/parquet/ParquetEncoding.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/ParquetTypeUtils.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/AbstractTestParquetReader.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/AbstractTestParquetReader.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/AbstractTestParquetReader.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/AbstractTestParquetReader.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/AbstractTestParquetReader.java
Outdated
Show resolved
Hide resolved
d612d9e
to
cc9e664
Compare
@raunaqmorarka could you please review it again? I thought I can resolve conflicts after basic review is done. Please let me know if I should fix it first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the merge conflicts and squash commits.
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/CustomParquetWriter.java
Outdated
Show resolved
Hide resolved
...trino-parquet/src/main/java/io/trino/parquet/reader/decoders/ApacheParquetValueDecoders.java
Outdated
Show resolved
Hide resolved
...trino-parquet/src/main/java/io/trino/parquet/reader/decoders/ApacheParquetValueDecoders.java
Outdated
Show resolved
Hide resolved
...trino-parquet/src/main/java/io/trino/parquet/reader/decoders/ApacheParquetValueDecoders.java
Show resolved
Hide resolved
...trino-parquet/src/main/java/io/trino/parquet/reader/decoders/ApacheParquetValueDecoders.java
Show resolved
Hide resolved
499cf9e
to
44bd0b0
Compare
44bd0b0
to
2bce6f1
Compare
9ddbcc8
to
3f5fd2f
Compare
@raunaqmorarka I am working on a testcase for float. Appreciate if you can review on rest of changes. |
@raunaqmorarka can you please follow up for @manupatteri |
53344fa
to
e43da5b
Compare
@raunaqmorarka @mosabua I have added tests for float as well. Kindly review it again and let me know your comments. |
a4eb241
to
41bb4d5
Compare
lib/trino-parquet/src/test/java/io/trino/parquet/reader/TestByteStreamSplitParquet.java
Outdated
Show resolved
Hide resolved
...trino-parquet/src/main/java/io/trino/parquet/reader/decoders/ApacheParquetValueDecoders.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/test/java/io/trino/parquet/reader/TestByteStreamSplitEncoding.java
Show resolved
Hide resolved
59cb9bf
to
824e8b7
Compare
@raunaqmorarka org.apache.parquet.io.ParquetDecodingException: Invalid ByteStreamSplit stream, num values upper bound (w/ nulls): 0, num encoded values: 100
To fix that I had to introduce changes in "initialize" method(to use correct valueCount in ValuesReader::initFromPage call) |
e8f5639
to
db166a5
Compare
Introduced DoubleApacheParquetValueDecoder and FloatApacheParquetValueDecoder to handle double and float types respectively
db166a5
to
1681912
Compare
Description
Support reading BYTE_STREAM_SPLIT encoding in parquet
Related issues, pull requests, and links
Fixes #8357
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: