Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated docs on impersonation limitations in Hive security #12620

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Remove outdated docs on impersonation limitations in Hive security #12620

merged 1 commit into from
Jun 1, 2022

Conversation

colebow
Copy link
Member

@colebow colebow commented May 31, 2022 •
edited
Loading

Description

These docs are out of date, and we support impersonation for all operations, so we can delete the list specifying what we do and don't support.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Docs

How would you describe this change to a non-technical end user or system administrator?

Updating docs

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label May 31, 2022
@colebow colebow requested review from mosabua and findepi May 31, 2022 21:31
@mosabua mosabua added the docs label May 31, 2022
@colebow colebow force-pushed the colebow/impersonation-docs branch from e691097 to ec7d9be Compare May 31, 2022 21:38
@colebow colebow requested a review from electrum May 31, 2022 21:39
mosabua
mosabua approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @electrum impersonation applies to all metastore operations and as such this removal is correct.

@colebow colebow force-pushed the colebow/impersonation-docs branch from ec7d9be to 632f3a0 Compare June 1, 2022 20:55
@colebow colebow changed the title Update docs on impersonation in Hive security Remove outdated docs on impersonation limitations in Hive security Jun 1, 2022
@martint martint merged commit 7348841 into trinodb:master Jun 1, 2022
@github-actions github-actions bot added this to the 383 milestone Jun 1, 2022
@colebow colebow mentioned this pull request Jun 1, 2022
Merged
@colebow colebow deleted the colebow/impersonation-docs branch June 2, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@mosabua mosabua mosabua approved these changes

@findepi findepi Awaiting requested review from findepi

@electrum electrum Awaiting requested review from electrum

Assignees
No one assigned
Labels
cla-signed docs
Milestone
383
Development

Successfully merging this pull request may close these issues.
4 participants
@colebow @mosabua @ebyhr @martint