Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for iceberg parameters extracted from hive config #12619

Conversation

homar
Copy link
Member

@homar homar commented May 31, 2022

Description

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@colebow
Copy link
Member

colebow commented May 31, 2022

Should we also include a release note for this change overall? Something on the Iceberg connector, like Remove HiveConfig and add support for the relevant configuration properties or something to that extent?

Copy link
Member

@colebow colebow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % changes

docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved
@homar
Copy link
Member Author

homar commented May 31, 2022

Should we also include a release note for this change overall? Something on the Iceberg connector, like Remove HiveConfig and add support for the relevant configuration properties or something to that extent?

Makes sense, I will do it. Thanks

@homar homar force-pushed the homar/add_docs_for_iceberg_parameters_extracted_from_hive_config branch from 637e562 to 2b717fa Compare May 31, 2022 22:19
docs/src/main/sphinx/release/release-382.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/release/release-382.md Outdated Show resolved Hide resolved
@homar homar force-pushed the homar/add_docs_for_iceberg_parameters_extracted_from_hive_config branch from 2b717fa to fe010d6 Compare June 1, 2022 07:18
@ebyhr ebyhr marked this pull request as ready for review June 1, 2022 07:33
@ebyhr ebyhr added no-release-notes This pull request does not require release notes entry and removed release-notes labels Jun 1, 2022
@ebyhr ebyhr merged commit 2d37201 into trinodb:master Jun 1, 2022
@ebyhr
Copy link
Member

ebyhr commented Jun 1, 2022

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed docs no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

3 participants