Fix bounds check in MultiChannelGroupByHash and BigintGroupByHash #12597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an off-by-one error in the check that can cause a failure when the page is empty
skrzypo987
approved these changes
May 31, 2022
Probably. IMO it needs a cleanup of |
|
Do we want to include a release note for this? |
No. This fixed bug in non-released version |
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Jun 9, 2022
Cherry-pick of trinodb/trino#12597 There's an off-by-one error in the check that can cause a failure when the page is empty. Co-authored-by: Karol Sobczak <[email protected]>
highker
pushed a commit
to prestodb/presto
that referenced
this pull request
Aug 3, 2022
Cherry-pick of trinodb/trino#12597 There's an off-by-one error in the check that can cause a failure when the page is empty. Co-authored-by: Karol Sobczak <[email protected]>
shrinidhijoshi
pushed a commit
to shrinidhijoshi/presto
that referenced
this pull request
Sep 7, 2022
Cherry-pick of trinodb/trino#12597 There's an off-by-one error in the check that can cause a failure when the page is empty. Co-authored-by: Karol Sobczak <[email protected]>
aaneja
reviewed
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an off-by-one error in the check that
can cause a failure when the page is empty
Description
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: