Fix formatting cumulative memory in Web UI #12596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
radek-kondziolka
approved these changes
May 30, 2022
|
Previously:
|
|
Can you please make labeller apply the |
findepi
reviewed
May 30, 2022
| </td> | ||
| {taskRetriesEnabled && | ||
| <td className="info-failed"> | ||
| {formatDataSizeBytes(query.queryStats.failedCumulativeUserMemory / 1000.0) + " seconds"} | ||
| {formatDataSize(query.queryStats.failedCumulativeUserMemory / 1000.0) + "*seconds"} |
There was a problem hiding this comment.
MB*s ? (MBs would be correct, but not clear)
There was a problem hiding this comment.
I started with MBs but yeah, I think it is not clear.
Elsewhere we use full seconds (not an abbreviation), so I guess this is fine.
losipiuk
added
needs-docs
Value for cumulative memory of a query was previously reported using following format: "4.33T seconds". It is not obviouls that it represents integer of memory coinsumption over time. This commit changes format to: "4.33TB*seconds"
losipiuk
force-pushed
the
lo/fix-formating-cm
branch
from
5ccddb0 to
5fd2387
Compare
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value for cumulative memory of a query was previously reported using
following format:
"4.33T seconds". It is not obviouls that it represents integer of memory
coinsumption over time.
This commit changes format to:
"4.33TB*seconds"
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: