Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Elasticsearch docs #12578

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

colebow
Copy link
Member

@colebow colebow commented May 27, 2022

Description

This cleans up the Elasticsearch docs, moving our base config properties and TLS config properties into tables, revises the wording, and also adds the property that enables TLS, which was previously un-documented.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Docs

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label May 27, 2022
@github-actions github-actions bot added the docs label May 27, 2022
@colebow colebow changed the title Colebow/elastic search docs Clean up Elasticsearch docs May 27, 2022
@colebow colebow requested review from mosabua and martint May 27, 2022 15:48
@mosabua mosabua requested a review from bitsondatadev May 31, 2022 19:21
@colebow colebow force-pushed the colebow/elastic-search-docs branch from d89ae0a to d38646b Compare May 31, 2022 21:23
@martint martint merged commit 48dab89 into trinodb:master Jun 1, 2022
@github-actions github-actions bot added this to the 383 milestone Jun 1, 2022
@colebow colebow deleted the colebow/elastic-search-docs branch June 2, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants