Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record connectors used in delta lake test environments #12532

Merged
merged 2 commits into from
May 26, 2022

Conversation

nineinchnick
Copy link
Member

Description

Delta-lake product test environments should correctly define which connectors they use, so that these tests won't be executed in PRs with changes only in modules not related to the Delta Lake plugin.

Is this change a fix, improvement, new feature, refactoring, or other?
test improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
product tests

How would you describe this change to a non-technical end user or system administrator?
n/a

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 24, 2022
@nineinchnick nineinchnick requested a review from findinpath May 24, 2022 12:25
@findinpath findinpath requested review from findepi and ebyhr May 24, 2022 12:45
@findepi findepi requested review from MiguelWeezardo and hashhar May 24, 2022 13:29
@findinpath
Copy link
Contributor

I'm assuming that the suide-ldap issues are unrelated to this PR:

2022-05-24 22:40:56 INFO: FAILURE     /    io.trino.tests.product.cli.TestTrinoLdapCli.shouldPassForCredentialsWithSpecialCharacters (Groups: profile_specific_tests, ldap_cli, ldap) took 0.0 seconds
tests               | 2022-05-24 22:40:56 SEVERE: Failure cause:
tests               | java.lang.NullPointerException: ldapTruststorePath is null
tests               | 	at java.base/java.util.Objects.requireNonNull(Objects.java:246)
tests               | 	at io.trino.tests.product.cli.TestTrinoLdapCli.launchTrinoCliWithServerArgument(TestTrinoLdapCli.java:324)

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label May 25, 2022
@ebyhr ebyhr merged commit d8e99b0 into trinodb:master May 26, 2022
@ebyhr
Copy link
Member

ebyhr commented May 26, 2022

Merged, thanks!

@nineinchnick nineinchnick deleted the delta-lake-pt-env branch May 26, 2022 09:31
@github-actions github-actions bot added this to the 383 milestone May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

6 participants