Refactor table function analysis #12407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
May 16, 2022
| @@ -1488,7 +1488,7 @@ protected Scope visitTableFunctionInvocation(TableFunctionInvocation node, Optio | |||
| ConnectorTransactionHandle transactionHandle = transactionManager.getConnectorTransaction( | |||
| session.getRequiredTransactionId(), | |||
| getRequiredCatalogHandle(metadata, session, node, catalogName.getCatalogName())); | |||
| ConnectorTableFunction.Analysis functionAnalysis = function.analyze(session.toConnectorSession(catalogName), transactionHandle, passedArguments); | |||
| io.trino.spi.ptf.Analysis functionAnalysis = function.analyze(session.toConnectorSession(catalogName), transactionHandle, passedArguments); | |||
There was a problem hiding this comment.
rename Analysis so it can be imported here
findepi
reviewed
May 16, 2022
| * gathered at analysis time. Typically, these are the values of the constant arguments, and results | ||
| * of pre-processing arguments. | ||
| */ | ||
| public class Analysis |
There was a problem hiding this comment.
final (this is SPI, so let's be defensive)
The `analyze()` method of a `ConnectorTableFunction` must be implemented by every subclass. It is now marked as abstract.
kasiafi
force-pushed
the
349PTFAnalysisRefactor
branch
from
c2ef5be to
131dc44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor around table function Analysis.
This is a SPI change. No release notes needed if this change is merged before the upcoming release (the main change has not been yet released)
This change has to be taken into account in the documentation (#12338)