Document client timeout in query management properties #12327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla. |
|
|
colebow
force-pushed
the
colebow/client-timeout-docs
branch
from
04948ff to
648e4b3
Compare
mosabua
requested changes
May 12, 2022
colebow
force-pushed
the
colebow/client-timeout-docs
branch
from
648e4b3 to
237e430
Compare
colebow
force-pushed
the
colebow/client-timeout-docs
branch
from
237e430 to
52aea64
Compare
mosabua
approved these changes
May 16, 2022
colebow
force-pushed
the
colebow/client-timeout-docs
branch
from
52aea64 to
a407cef
Compare
electrum
approved these changes
May 20, 2022
colebow
force-pushed
the
colebow/client-timeout-docs
branch
from
a407cef to
01f88ad
Compare
|
@electrum updated the value, can we get this merged? |
jhlodin
approved these changes
May 23, 2022
|
@martint can we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a simple fix to include the property for client timeout. Noted that it probably shouldn't be changed, but none of the other properties are editorialized, so I stuck with that and decided not to include a note to that extent.
Improvement
Documentation
We are adding documentation!
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: