Initialize AbstractTestQueryFramework lazily #12188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access `queryRunner`, `h2QueryRunner` and `queryAssertions` with getters.
findepi
requested review from
nineinchnick,
losipiuk,
MiguelWeezardo,
hashhar and
findinpath
findepi
commented
Apr 29, 2022
testing/trino-testing/src/main/java/io/trino/testing/AbstractTestQueryFramework.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/fix-class-ordering-maybe
branch
from
5aee9a0 to
213587e
Compare
findinpath
reviewed
Apr 29, 2022
testing/trino-testing/src/main/java/io/trino/testing/AbstractTestQueryFramework.java
Show resolved
Hide resolved
losipiuk
reviewed
Apr 29, 2022
testing/trino-testing/src/main/java/io/trino/testing/AbstractTestQueryFramework.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/fix-class-ordering-maybe
branch
3 times, most recently
from
3394490 to
562c77c
Compare
Previously the `AbstractTestQueryFramework` was initialized with `@BeforeClass`. This was a clean approach but led to surefire+TestNG problem https://issues.apache.org/jira/browse/SUREFIRE-1967: multiple test instances being initialized and kept around while only two (or whatever test parallelism is) are actually needed. This in turn led to tests potentially exhausting available memory and failing with OOM. This commit tries to workaround this problem by introducing lazy initialization in `AbstractTestQueryFramework`. It has not been verified whether this solves the problem. Also, timing of class tear-down wasn't verified either.
findepi
force-pushed
the
findepi/fix-class-ordering-maybe
branch
from
562c77c to
eb05bfd
Compare
|
i added a however, |
findepi
added
the
no-release-notes
|
@hashhar suggested that simply switching to @hashhar @findinpath let me know your feedback from the testing |
|
converted to draft. May be unnecessary after #12192 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
AbstractTestQueryFrameworkwas initialized with@BeforeClass. This was a clean approach but led to surefire+TestNGproblem https://issues.apache.org/jira/browse/SUREFIRE-1967: multiple
test instances being initialized and kept around while only two (or
whatever test parallelism is) are actually needed. This in turn led to
tests potentially exhausting available memory and failing with OOM.
This PR tries to workaround this problem by introducing lazy
initialization in
AbstractTestQueryFramework. It has not been verifiedwhether this solves the problem. Also, timing of class tear-down wasn't
verified either.