Remove DeltaLakeGlueMetastoreTableFilterProvider.isDeltaLakeTable #12120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homar
force-pushed
the
homar/remove_unnecesary_todo
branch
from
02b3683 to
1466095
Compare
findepi
reviewed
Apr 25, 2022
| @@ -51,7 +51,6 @@ private static boolean isDeltaLakeTable(Table table) | |||
| if (parameters == null) { | |||
| return false; | |||
| } | |||
| // todo; add parameters == null check to DefaultGlueMetastoreTableFilterProvider.isDeltaLakeTable (https://github.com/trinodb/trino/issues/12013) | |||
There was a problem hiding this comment.
remove Map<String, String> parameters = table.getParameters(); above too
There was a problem hiding this comment.
Why ? To me it is a 'fast path' for returning false. @findepi
There was a problem hiding this comment.
it's a code piece that is now redundant. we wouldn't write it originally if DefaultGlueMetastoreTableFilterProvider.isDeltaLakeTable didn't have a problem
actually, the whole method should get inlined now
homar
force-pushed
the
homar/remove_unnecesary_todo
branch
from
1466095 to
10ac9b2
Compare
homar
changed the title
|
@findepi is it better now? |
findepi
reviewed
Apr 26, 2022
| @@ -40,7 +40,7 @@ public DeltaLakeGlueMetastoreTableFilterProvider(DeltaLakeGlueMetastoreConfig co | |||
| public Predicate<Table> get() | |||
| { | |||
| if (hideNonDeltaLakeTables) { | |||
| return DeltaLakeGlueMetastoreTableFilterProvider::isDeltaLakeTable; | |||
| return DefaultGlueMetastoreTableFilterProvider::isDeltaLakeTable; | |||
There was a problem hiding this comment.
io.trino.plugin.deltalake.metastore.glue.DeltaLakeGlueMetastoreTableFilterProvider#isDeltaLakeTable is now unused
There was a problem hiding this comment.
:| i pressed cmd+z too many times...
Replace it with DefaultGlueMetastoreTableFilterProvider.isDeltaLakeTable
homar
force-pushed
the
homar/remove_unnecesary_todo
branch
from
10ac9b2 to
e36ea1d
Compare
findepi
approved these changes
Apr 26, 2022
findepi
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace it with DefaultGlueMetastoreTableFilterProvider.isDeltaLakeTable.
Base on b7c07f2 tt looks like we don't want to do it anymore.
fixes: #12013
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: