Fix incorrect predicate precedence involving OR and split predicates #12078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Apr 21, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/expression/RewriteOr.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/fix-getAdditionalPredicate
branch
from
61239a9 to
16fa861
Compare
findepi
reviewed
Apr 21, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/fix-getAdditionalPredicate
branch
from
16fa861 to
d4fdd76
Compare
wendigo
force-pushed
the
serafin/fix-getAdditionalPredicate
branch
from
d4fdd76 to
56d8d19
Compare
findepi
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If constraintExpressions contain translated
ORexpression and there is a split predicate, resulting predicate could be incorrect:predicate1 OR predicate2 AND splitPredicate. Instead we need to wrap both sides of OR expression with parens:(predicate1 OR predicate2) AND splitPredicate