Document row level deletes for Iceberg #12061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Apr 21, 2022
| ^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Tables using v2 of the Iceberg specification support deletion of individual rows | ||
| using the ``merge-on-read`` mode. In order to use this feature the ``format_version`` |
There was a problem hiding this comment.
merge-on-read in monospace looks like we support deletes only if deletion mode is merge-on-read, while we ignore it
let's not use the merge-on-read in a code block. Let's say we create deletion files.
|
|
||
| Tables using v2 of the Iceberg specification support deletion of individual rows | ||
| using the ``merge-on-read`` mode. In order to use this feature the ``format_version`` | ||
| table property must be set to ``2``. |
There was a problem hiding this comment.
- for new Tables, from Trino perspective, user doesn't need to set
format_version=2, because it's the default - for existing tables, referring to
format_versionmay be confusing because we don't show it yet (Show Iceberg table version in SHOW CREATE TABLE #11980) and don't allow changing it (tbd)
let's just say the table must be in "v2" iceberg spec version
| Currently, the Iceberg connector only supports deletion by partition. | ||
| This SQL below will fail because the ``WHERE`` clause selects only some of the rows | ||
| in the partition:: | ||
| Both v1 and v2 tables will perform a partition delete if the ``WHERE`` clause |
There was a problem hiding this comment.
Is it clear that v1 and v2 refer to Iceberg spec versions?
alexjo2144
force-pushed
the
iceberg/delete-docs
branch
from
7441a4e to
23f580c
Compare
|
Updated, thanks |
findepi
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation for #11886
Documentation of a new feature