Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in docs of kafka connector #11809

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Fix typo in docs of kafka connector #11809

merged 1 commit into from
Apr 6, 2022

Conversation

ysn2233
Copy link
Contributor

@ysn2233 ysn2233 commented Apr 6, 2022

In the docs of kafka connector, somewhere it should be 'dataformat' instead of 'dateformat'

Description

Is this change a fix, improvement, new feature, refactoring, or other?
typo fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
no

@cla-bot cla-bot bot added the cla-signed label Apr 6, 2022
@github-actions github-actions bot added the docs label Apr 6, 2022
ebyhr
ebyhr approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the commit message as "Fix typo in Kafka documentation"?

@ysn2233
Copy link
Contributor Author

ysn2233 commented Apr 6, 2022

Could you fix the commit message as "Fix typo in Kafka documentation"?

Fixed

@ebyhr
Copy link
Member

ebyhr commented Apr 6, 2022

@ysn2233 Please capitalize the commit message.
https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Apr 6, 2022
@ysn2233
Copy link
Contributor Author

ysn2233 commented Apr 6, 2022

@ysn2233 Please capitalize the commit message. https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages

done

@ebyhr ebyhr merged commit df3d232 into trinodb:master Apr 6, 2022
@ebyhr
Copy link
Member

ebyhr commented Apr 6, 2022

Thanks!

@github-actions github-actions bot added this to the 376 milestone Apr 6, 2022
@ysn2233 ysn2233 changed the title fix typo in docs of kafka connector Fix typo in docs of kafka connector Apr 6, 2022
@mosabua mosabua mentioned this pull request Apr 6, 2022
Merged
v-jizhang added a commit to v-jizhang/presto that referenced this pull request Apr 8, 2022
@v-jizhang @ysn2233
Fix typo in docs of kafka connector
d4e0707 
trinodb/trino#11809

Co-authored-by: yushengnan <[email protected]>
@v-jizhang v-jizhang mentioned this pull request Apr 8, 2022
Merged
highker pushed a commit to prestodb/presto that referenced this pull request Apr 15, 2022
@v-jizhang @ysn2233 @highker
Fix typo in docs of kafka connector
b32214e 
trinodb/trino#11809

Co-authored-by: yushengnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

Assignees
No one assigned
Labels
cla-signed docs no-release-notes This pull request does not require release notes entry
Milestone
376
Development

Successfully merging this pull request may close these issues.
2 participants
@ysn2233 @ebyhr