Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Parquet MetadataReader tests #11793

Merged
merged 3 commits into from
Apr 6, 2022
Merged

More Parquet MetadataReader tests #11793

merged 3 commits into from
Apr 6, 2022

Conversation

findepi
Copy link
Member

@findepi findepi commented Apr 5, 2022

No description provided.

@findepi findepi added test no-release-notes This pull request does not require release notes entry labels Apr 5, 2022
@cla-bot cla-bot bot added the cla-signed label Apr 5, 2022
homar
homar approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@homar homar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about deduplicating it a little but led to quite complex invocations so LGTM

@findepi findepi merged commit 5ce1603 into trinodb:master Apr 6, 2022
@findepi findepi deleted the findepi/pqs2 branch April 6, 2022 09:59
@github-actions github-actions bot added this to the 376 milestone Apr 6, 2022
@mosabua mosabua mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@homar homar homar approved these changes

@alexjo2144 alexjo2144 Awaiting requested review from alexjo2144

@hashhar hashhar Awaiting requested review from hashhar

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry test
Milestone
376
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @homar @ebyhr