Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check input in trino-cli in batch mode #11754

Merged

Conversation

nineinchnick
Copy link
Member

@nineinchnick nineinchnick commented Apr 1, 2022

Description

Trino CLI can be run with --execute, --file or by passing queries to stdin. It's not necessary to check for input in these cases. If --progress is also used, trino-cli checks for user input, and introduces a delay in executing queries. Only when queries are passed to stdin, there's no tty, and there's no delay.

Is this change a fix, improvement, new feature, refactoring, or other?

fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

cli client

How would you describe this change to a non-technical end user or system administrator?

When trino-cli is run in batch mode but with --progress, there's no unnecessary delay in executing queries.

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Apr 1, 2022
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Apr 4, 2022
@findepi findepi merged commit 51722c5 into trinodb:master Apr 4, 2022
@nineinchnick nineinchnick deleted the cli-dont-check-input-in-batch-mode branch April 4, 2022 09:01
@github-actions github-actions bot added this to the 376 milestone Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants