Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit log.path definition and remove default value #11705

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Edit log.path definition and remove default value #11705

merged 1 commit into from
Apr 7, 2022

Conversation

rosewms
Copy link
Contributor

@rosewms rosewms commented Mar 29, 2022

Description

  • Edit definition to mention that the var/log/server.log is configured by the launching script
  • Remove default value, it is not defined in airlift

Is this change a fix, improvement, new feature, refactoring, or other? Fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? Logging properties

How would you describe this change to a non-technical end user or system administrator? See description

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Mar 29, 2022
@github-actions github-actions bot added the docs label Mar 29, 2022
Ordinant
Ordinant approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@Ordinant Ordinant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unimproveable

@hashhar hashhar requested review from electrum and removed request for hashhar April 4, 2022 05:13
@mosabua
Copy link
Member

mosabua commented Apr 6, 2022

@hashhar or @ebyhr could you maybe check and approve?

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Apr 7, 2022
@ebyhr ebyhr merged commit 849bf04 into trinodb:master Apr 7, 2022
@github-actions github-actions bot added this to the 376 milestone Apr 7, 2022
@mosabua mosabua mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@Ordinant Ordinant Ordinant approved these changes

@jhlodin jhlodin jhlodin approved these changes

@radek-kondziolka radek-kondziolka Awaiting requested review from radek-kondziolka

@electrum electrum Awaiting requested review from electrum

Assignees
No one assigned
Labels
cla-signed docs no-release-notes This pull request does not require release notes entry
Milestone
376
Development

Successfully merging this pull request may close these issues.
5 participants
@rosewms @mosabua @jhlodin @Ordinant @ebyhr