Pre-allocate definition & repetition levels; perf improvement

[theosib-amazon]

Testing shows 5% to 15% performance improvement on a lot of queries by pre-reserving capacity for definitionLevels and repetitionLevels.

Description

I did profiling on Trino while doing TPCDS queries from a Parquet source and noticed that a lot of them were wasting time on array copy while growing capacity of the definitionLevels and definitionLevels integer array lists. Pre-reserving capacity sped up a lot of queries, some as much as 15%.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Change to the parquet reader component

How would you describe this change to a non-technical end user or system administrator?

Speed up parquet column reading a bit by pre-reserving capacity in some of the containers.

Related issues, pull requests, and links

Performance optimization

Documentation

(x) No documentation is needed.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# Hive
* Improve performance when reading Parquet data. ({issue}`11675`)

# Iceberg
* Improve performance when reading Parquet data. ({issue}`11675`)

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

[theosib-amazon]

I submitted my CLA a week ago; hopefully that will be acted upon soon.

[raunaqmorarka]

Please get rid of the merge commit

[skrzypo987]

LGTM % Raunaq comment

[skrzypo987]

@cla-bot check

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to [email protected]. For more information, see https://github.com/trinodb/cla.

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[skrzypo987]

@martint Have you received a CLA from @theosib-amazon ?

[theosib-amazon]

Should I resubmit my CLA some other way?

[theosib-amazon]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[martint]

Merged as 086d56f. Thanks!