Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the non-implemented metadata method isn't called #11599

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Make sure the non-implemented metadata method isn't called #11599

merged 1 commit into from
Mar 23, 2022

Conversation

findepi
Copy link
Member

@findepi findepi commented Mar 21, 2022

Ensures that Delta Lake's and Hive's metadata doesn't return incorrect
information when listTableColumns is invoked. The connectors implement
streamTableColumns, which is supposed to be used always.

@findepi
Make sure the non-implemented metadata method isn't called
eb079de 
Ensures that Delta Lake's and Hive's metadata doesn't return incorrect
information when `listTableColumns` is invoked. The connectors implement
`streamTableColumns`, which is *supposed* to be used always.
@findepi findepi added maintenance Project maintenance task no-release-notes This pull request does not require release notes entry labels Mar 21, 2022
@cla-bot cla-bot bot added the cla-signed label Mar 21, 2022
@findepi findepi mentioned this pull request Mar 21, 2022
Merged
@alexjo2144
Copy link
Member

If listTableColumns is supposedly never called should we just change the default implementation in the interface to throw this exception?

@findinpath
Copy link
Contributor

If listTableColumns is supposedly never called should we just change the default implementation in the interface to throw this exception?

io.trino.spi.connector.ConnectorMetadata#streamTableColumns calls by default listTableColumns and there is a bunch of connectors still overriding this method.

@findepi
Copy link
Member Author

findepi commented Mar 21, 2022

If listTableColumns is supposedly never called should we just change the default implementation in the interface to throw this exception?

listTableColumns remains for backward compatibility reasons.
(yes, we should eventually remove it)

@findepi findepi merged commit 3125569 into trinodb:master Mar 23, 2022
@findepi findepi deleted the findepi/make-sure-the-non-implemented-metadata-method-isn-t-called-a0365a branch March 23, 2022 07:12
@github-actions github-actions bot added this to the 375 milestone Mar 23, 2022
@mosabua mosabua mentioned this pull request Mar 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phd3 phd3 phd3 approved these changes

@findinpath findinpath findinpath approved these changes

@losipiuk losipiuk Awaiting requested review from losipiuk

@alexjo2144 alexjo2144 Awaiting requested review from alexjo2144

Assignees
No one assigned
Labels
cla-signed maintenance Project maintenance task no-release-notes This pull request does not require release notes entry
Milestone
375
Development

Successfully merging this pull request may close these issues.
4 participants
@findepi @alexjo2144 @findinpath @phd3