Wait for rules to be refreshed in BaseCaseInsensitiveMappingTest #11506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
added
the
no-release-notes
findepi
reviewed
Mar 16, 2022
Comment on lines
361
to
362
| // wait to ensure rules have been refreshed | ||
| Thread.sleep(2 * ruleRefreshPeriod.toMillis()); |
There was a problem hiding this comment.
To be safe. should be refreshPeriod + some delta
There was a problem hiding this comment.
Kept 2x, moved sleep to the Utils class.
There was a problem hiding this comment.
should be refreshPeriod + some delta
i don't believe it should
To be safe.
fine, keep it.
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseCaseInsensitiveMappingTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseCaseInsensitiveMappingTest.java
Outdated
Show resolved
Hide resolved
| @@ -307,7 +312,7 @@ public void testTableNameClashWithRuleMapping() | |||
| public void testSchemaAndTableNameRuleMapping() | |||
| throws Exception | |||
| { | |||
| updateRuleBasedIdentifierMappingFile( | |||
| updateRuleBasedIdentifierMappingFileAndWait( | |||
There was a problem hiding this comment.
Even if you introduce a new method, it could be called updateRuleBasedIdentifierMappingFile (without "AndWait")
- smaller diff
- it makes it much harder to invoke the old method directly, since it's shadowed
There was a problem hiding this comment.
Moved sleep to existing method. Thanks.
hashhar
force-pushed
the
hashhar/sleep-in-test
branch
from
b33f6b6 to
e6b2bba
Compare
kokosing
approved these changes
Mar 16, 2022
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseCaseInsensitiveMappingTest.java
Outdated
Show resolved
Hide resolved
hashhar
force-pushed
the
hashhar/sleep-in-test
branch
from
e6b2bba to
68c1b8d
Compare
A refresh period of 1ms doesn't guarantee that rules will be refreshed before they are used. Since the rules are refreshed synchronously we sleep for 2*refresh period to guarantee that rules are refreshed.
hashhar
force-pushed
the
hashhar/sleep-in-test
branch
from
68c1b8d to
8d818e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refresh period of 1ms doesn't guarantee that rules will be refreshed
before they are used. Since the rules are refreshed synchronously we
sleep for 2*refresh period to guarantee that rules are refreshed.
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.