Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support UInt8, UInt16, UInt32 and UInt64 types in ClickHouse #11490

Merged
merged 5 commits into from
Mar 16, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Mar 15, 2022

Description

Support UInt8, UInt16, UInt32, UInt64 types in ClickHouse
Request in the community Slack: https://trinodb.slack.com/archives/CGB0QHWSW/p1647319914845359

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# ClickHouse
* Add support for `uint8`, `uint16`, `uint32` and `uint64` types. ({issue}`11490`)

Additionally, fix indentation for UUID mapping line.
@cla-bot cla-bot bot added the cla-signed label Mar 15, 2022
@github-actions github-actions bot added the docs label Mar 15, 2022
@ebyhr ebyhr requested a review from hashhar March 15, 2022 23:51
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebyhr ebyhr force-pushed the ebi/clickhouse-uint64 branch from ef1bf1a to 7b99169 Compare March 16, 2022 06:09
@ebyhr ebyhr merged commit 0777c46 into trinodb:master Mar 16, 2022
@ebyhr ebyhr deleted the ebi/clickhouse-uint64 branch March 16, 2022 10:46
@ebyhr ebyhr mentioned this pull request Mar 16, 2022
@github-actions github-actions bot added this to the 374 milestone Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants