Test access control functionality in the context of table redirections #11488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
force-pushed
the
table-redirection-access-control-tests
branch
from
df554e5 to
5a72611
Compare
kokosing
approved these changes
Mar 15, 2022
findinpath
force-pushed
the
table-redirection-access-control-tests
branch
from
5a72611 to
5a80d07
Compare
findinpath
force-pushed
the
table-redirection-access-control-tests
branch
from
5a80d07 to
a5b9265
Compare
findinpath
force-pushed
the
table-redirection-access-control-tests
branch
from
a5b9265 to
f6dec74
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the addition of the new functionality related to adding table redirection awareness to multiple SQL commands in Trino there needs to be invested additional effort in making sure that the access control works as expected when performing table redirections.
Note that the new tests from this PR don't aim to replace the tests from the class
io.trino.security.TestAccessControl, but rather enrich the suite of tests for the access control.Any new table redirection awareness change on a SQL command should add a corresponding test to the class
io.trino.security.TestAccessControlTableRedirection.Test
This test is ensuring that the access control functionality which is part of the core query engine works as expected.
This PR aims to add basic access control tests for the existing commands doing table redirects.
Depending on the connector, a table redirect can point to another table in the same schema or to a table in a different connector. This PR makes sure that the access control checks for the appropriate permissions on the redirected table and not on the source table.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: