Process function path #11476
Process function path #11476
Conversation
|
cc @kasiafi |
|
|
||
| private Collection<FunctionMetadata> getFunctions(CatalogSchemaFunctionName name) | ||
| { | ||
| if (name.getCatalogName().equals(GLOBAL_CATALOG)) { |
There was a problem hiding this comment.
Do we prevent creating a catalog with this name?
There was a problem hiding this comment.
The "system" catalog is the built in catalog that is information like the nodes in the cluster, and metadata for the jdbc driver.
| String catalog = sqlPathElement.getCatalog().map(Identifier::getValue).or(session::getCatalog) | ||
| .orElseThrow(() -> new IllegalArgumentException("Session default catalog must be set to resolve a partial function name: " + null)); | ||
| names.add(new CatalogSchemaFunctionName(catalog, sqlPathElement.getSchema().getValue(), functionName)); |
There was a problem hiding this comment.
Could you use getCanonicalValue() instead of getValue()?
I think it's no difference at the moment, as all the names are eventually lowercased, but it would simplify the future transition to SQL identifier semantics.
There was a problem hiding this comment.
Sure. Didn't know that method existed.
dain
force-pushed
the
function-refactor-path
branch
from
6b7d00a to
b09cfbc
Compare
core/trino-main/src/main/java/io/trino/metadata/FunctionMetadata.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/rowpattern/LogicalIndexExtractor.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/FunctionResolver.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/SchemaFunctionName.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/CatalogSchemaFunctionName.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
function-refactor-path
branch
from
b09cfbc to
bb44aeb
Compare
dain
force-pushed
the
function-refactor-path
branch
from
bb44aeb to
461d3ca
Compare
|
Does this conflict anyhow with #9831? |
At this point, I don't think so, but in the future maybe. Functions in SQL have a absolute name expressed just like a table with catalog and schema. We will eventually want to express full names to connectors so they can differentiate between functions in different schemas. That said, there is only one schema that has functions right now.
Yes, any pending functions will need to be updated to use the new builders. This translation is easy, so it shouldn't be too much work. |
Description
Related issues, pull requests, and links
Relates to #8
Documentation
There are no actual function namespaces yet, so this does not change anything user visible yet.
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
There are no actual function namespaces yet, so this does not change anything user visible yet.
(x) No release notes entries required.
() Release notes entries required with the following suggested text: