Make AWSCredentialProvider injectable to GlueMetastore #11456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
force-pushed
the
praveen/aws_glue_cleanup
branch
from
d88fceb to
938d7fc
Compare
findepi
requested review from
dain and
electrum
and removed request for
findepi
findinpath
reviewed
Mar 14, 2022
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastore.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
praveen/aws_glue_cleanup
branch
from
938d7fc to
247012e
Compare
kokosing
approved these changes
Mar 14, 2022
|
Could you please add some details in the commit message/ PR description about the advantages that come with this change? |
findinpath
approved these changes
Mar 14, 2022
lukasz-walkiewicz
approved these changes
Mar 14, 2022
electrum
reviewed
Mar 14, 2022
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueMetastoreModule.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
praveen/aws_glue_cleanup
branch
from
247012e to
8669c3a
Compare
|
@electrum Thanks for the review. Applied the comments. |
Praveen2112
force-pushed
the
praveen/aws_glue_cleanup
branch
3 times, most recently
from
8f449f0 to
c1ce5ce
Compare
Praveen2112
force-pushed
the
praveen/aws_glue_cleanup
branch
from
c1ce5ce to
7fa990d
Compare
kokosing
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring
Hive connector, specific to Glue metastore
no user facing change
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: