-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make matrix script process any matrix items #11446
Conversation
9cb33e8
to
1856b57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Is it necessary to expand the matrix? Can we just passthrough the matrix as it is and let GHA handle the expansion?
e.g. in current impl we don't correctly handle include where it matches an already existing entry in the matrix. We append instead of overriding exisitng entry in this impl.
i.e. would it work if we just converted the matrix.yaml
into a matrix.json
and let it be?
Yes, that'll work, we just have to filter by modules in both the matrix and include sections. Thanks for pointing this out, I'm also not very confident that our matrix expansion would work exactly the same as GHA does it. |
1856b57
to
df0b7b4
Compare
@nineinchnick Can you "test" by modifying the matrix to use in a commit:
The impl looks good to me % the case where includes overrides an existing module (a test would confirm). |
df0b7b4
to
ed9410f
Compare
I added tests in the script itself, PTAL. I'm not sure what you mean with overrides though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I meant the case you added for |
ed9410f
to
3f72391
Compare
Description
When #10323 introduced a script to filter out non-impacted modules from the the CI test matrix, this script was intentionally very simple and only handled the currently existing matrix. This PR extends it to:
include
section, not just currently used onesinclude
sectionThis allows future contributors to adjust the CI matrix as they see fit, without having to figure out how it's different than the regular GHA matrix.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: