Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return type of trim functions with char argument to varchar #11440

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Mar 12, 2022

Description

Change return type of trim functions with char argument to varchar

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# General
* Fix `trim`, `ltrim` and `rtim` function results when the argument is `char` type. 
  Previously, it returned padded results as `char` type. It returns `varchar` type without padding now. ({issue}`11440`)

@ebyhr ebyhr requested a review from kasiafi March 12, 2022 03:17
@cla-bot cla-bot bot added the cla-signed label Mar 12, 2022
@findepi
Copy link
Member

findepi commented Mar 14, 2022

Change return type of trim, ltrim and rtim functions with char arguments to varchar.

it's not only about return type.
For example, rtrim(char) was a no-op, the result was always the same as the input, so this fixes the return value as well.

@ebyhr ebyhr merged commit e84dff8 into trinodb:master Mar 15, 2022
@ebyhr ebyhr deleted the ebi/trim-chars branch March 15, 2022 00:18
@ebyhr ebyhr mentioned this pull request Mar 15, 2022
@github-actions github-actions bot added this to the 374 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants