Remove useless import in TableExecute #11426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyo-tom
force-pushed
the
remove_useless_import
branch
from
b082a8a to
bc4cff5
Compare
losipiuk
reviewed
Mar 11, 2022
| @@ -14,7 +14,6 @@ | |||
| package io.trino.sql.tree; | |||
|
|
|||
| import com.google.common.collect.ImmutableList; | |||
| import org.checkerframework.checker.units.qual.C; | |||
There was a problem hiding this comment.
I wonder why it was not reported by UnsedImports rule of checkstyle :/ @findepi ?
There was a problem hiding this comment.
because the class uses C as generic parameter name. i guess this apparently confused the checkstyle.
There was a problem hiding this comment.
because the class uses C as generic parameter name.
(for some methods)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove useless import in
io.trino.sql.tree.TableExecuteDocumentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: