Bump default fault tolerant task memory #11419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
force-pushed
the
lo/fault-tolerant-task-memory-fixes
branch
2 times, most recently
from
7c46a08 to
63de1f3
Compare
losipiuk
commented
Mar 10, 2022
|
|
||
| // enforced against user memory allocations | ||
| private DataSize maxQueryMemory = DataSize.of(20, GIGABYTE); | ||
| // enforced against user + system memory allocations (default is maxQueryMemory * 2) | ||
| private DataSize maxQueryTotalMemory; | ||
| private DataSize faultTolerantTaskMemory = DataSize.of(1, GIGABYTE); | ||
| private DataSize faultTolerantExecutionTaskMemory = DataSize.of(4, GIGABYTE); |
There was a problem hiding this comment.
Ideally it would be to define it as a fraction of worker heap but we do not have this information on coordinator statically available. Also every worker can be of different size theoretically.
arhimondr
approved these changes
Mar 10, 2022
losipiuk
force-pushed
the
lo/fault-tolerant-task-memory-fixes
branch
2 times, most recently
from
d8a12b1 to
2b25342
Compare
|
@arhimondr PTAL once again. I needed to make a fix. Hope test will be green now. |
losipiuk
force-pushed
the
lo/fault-tolerant-task-memory-fixes
branch
from
2b25342 to
190622a
Compare
If task memory requirements exceed memory capacity of any node in the cluster treat such task as if it would request full node.
Default value (4GB) does not match test environment well and would effectively require full node for each task.
losipiuk
force-pushed
the
lo/fault-tolerant-task-memory-fixes
branch
from
190622a to
b7f76a4
Compare
arhimondr
approved these changes
Mar 14, 2022
|
CI already fixed on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No release notes/docs needed (docs is upcoming as a separate PR)