Migrate most PostgreSQL type mapping tests to SqlDataTypeTest #11399

hashhar · 2022-03-09T19:18:19Z

Description

This migrates most tests except:

Tests of arrays containing null values - it's affected by Implement support for comparing arrays containing nulls #11397. The tests need to reimplemented some other way to avoid verifyPredicate from SqlDataTypeTest.
Tests of datetime types - these will be done in separate PR

(x) No documentation is needed.

(x) No release notes entries required.

plugin/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlTypeMapping.java

hashhar · 2022-03-10T01:52:49Z

PTAL at 2nd commit I added now - it moves hstore tests.

plugin/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlTypeMapping.java

cla-bot bot added the cla-signed label Mar 9, 2022

hashhar requested review from ebyhr and grantatspothero March 9, 2022 23:31

ebyhr approved these changes Mar 10, 2022

View reviewed changes

plugin/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlTypeMapping.java Show resolved Hide resolved

Migrate array related type mapping tests to SqlDataTypeTest

418fe92

hashhar force-pushed the hashhar/pg-sql-type-tests branch from f6ac98a to 05d5b18 Compare March 10, 2022 01:52

ebyhr approved these changes Mar 10, 2022

View reviewed changes

plugin/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlTypeMapping.java Outdated Show resolved Hide resolved

Migrate hstore related type mapping tests to SqlDataTypeTest

860c5e1

hashhar force-pushed the hashhar/pg-sql-type-tests branch from 05d5b18 to 860c5e1 Compare March 10, 2022 09:42

hashhar merged commit 2ce6cf4 into trinodb:master Mar 10, 2022

hashhar deleted the hashhar/pg-sql-type-tests branch March 10, 2022 10:43

github-actions bot added this to the 374 milestone Mar 10, 2022

mosabua mentioned this pull request Mar 10, 2022

Add Trino 374 release notes #11417

Merged