Replace BigArrays with primitive ones in BigInt aggregation #11392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
approved these changes
Mar 9, 2022
LongBigArray and IntBigArray with long[] and int[]. The original implementation was done because Java prior to version 11 had some problems handling humongous (very big) objects and that sometimes caused giant GC pauses. Since Java 11 humongous objects are first allocated on eden which mitigates problems with collecting them. before: BenchmarkGroupByHash.bigintGroupByHash 1 true avgt 10 60,944 ± 1,730 ns/op BenchmarkGroupByHash.bigintGroupByHash 1 false avgt 10 58,081 ± 1,310 ns/op after: BenchmarkGroupByHash.bigintGroupByHash 1 true avgt 10 49,011 ± 1,100 ns/op BenchmarkGroupByHash.bigintGroupByHash 1 false avgt 10 47,924 ± 2,408 ns/op
skrzypo987
force-pushed
the
skrzypo/060-long-aggregation-arrays
branch
from
a0c70fb to
ba9fcdc
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit extracted from #11031
Description
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: