-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Local Dynamic Filter test cases #11379
Refactor Local Dynamic Filter test cases #11379
Conversation
49e267a
to
8b7bc18
Compare
.addExtraProperty("dynamic-filtering.small-broadcast.max-distinct-values-per-driver", "100") | ||
.addExtraProperty("dynamic-filtering.small-broadcast.range-row-limit-per-driver", "100") | ||
.addExtraProperty("dynamic-filtering.large-broadcast.max-distinct-values-per-driver", "100") | ||
.addExtraProperty("dynamic-filtering.large-broadcast.range-row-limit-per-driver", "100000") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these configs be contributed by AbstractLocalDynamicFilteringTest. That way all subclasses can use the constant defined there. I don't think these values would need to vary per connector.
CI failure is related - new files have missing license header. you can add those by running |
I don't think the same test would make sense for both memory and hive connectors. In memory connector, |
8b7bc18
to
e7749c8
Compare
Ok. If that's the decision, then I can close this PR. Please let me know @sopel39 @hashhar. Thanks @raunaqmorarka. |
Yeah. I realized this later. I think it's fixed now. Now I am getting something which looks a system error. I will just do a git push again to trigger a re-run. |
e7749c8
to
40ad2ac
Compare
} | ||
|
||
@Test(timeOut = 30_000, dataProvider = "joinDistributionTypes") | ||
public void testJoinDynamicFilteringMultiJoin(OptimizerConfig.JoinDistributionType joinDistributionType) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually not about local dynamic filtering, but about how scheduler schedules stages (and it doesn't lock). So it's not local DF test. This maybe isn't the best place for it, but I couldn't find a better one
I agree with @raunaqmorarka |
Closing this PR as per discussion above. |
Description
Dynamic Filter(DF) is a common functionality in multiple connectors. Since functionality is similar, similar tests are present in different connectors. This is part of an effort to extract such common tests and make it available at a common layer. This will allow newer connectors or connectors where DF is getting introduced to write tests quickly and correctly.
Since the original issue was created multiple PRs were already merged which takes care of different aspects of this.(For eg: #9193).
Hence I am re-raising a new PR which takes care of common tests for local dynamic filters only. AFAIK it is available mainly in Memory Connector and Hive Connector.
Related issues, pull requests, and links
Fixes #5776
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: