Use assignments instead of variable name in Elasticsearch #11354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Mar 7, 2022
| @@ -546,14 +547,16 @@ public ConnectorTableProperties getTableProperties(ConnectorSession session, Con | |||
| // TODO Support ESCAPE character when it's pushed down by the engine | |||
| if (LIKE_PATTERN_FUNCTION_NAME.equals(call.getFunctionName()) && call.getArguments().size() == 2 && | |||
| call.getArguments().get(0) instanceof Variable && call.getArguments().get(1) instanceof Constant) { | |||
| String columnName = ((Variable) call.getArguments().get(0)).getName(); | |||
| String name = ((Variable) call.getArguments().get(0)).getName(); | |||
| Object pattern = ((Constant) call.getArguments().get(1)).getValue(); | ||
| if (!newRegexes.containsKey(columnName) && pattern instanceof Slice) { | ||
| if (!newRegexes.containsKey(column.getName()) && pattern instanceof Slice) { |
There was a problem hiding this comment.
Extract columnName variable for readability.
There is |
assaf2
force-pushed
the
use-assignments-elasticsearch
branch
from
08559e0 to
1e09a6b
Compare
I guess the test was not failing before the change, so while it exercises the code, it was not exactly what i was looking for. Anyway, perhaps we don't need that. |
findepi
approved these changes
Mar 8, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.