Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to valid comment in code snippet #11284

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Mar 2, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Fix since comment is currently invalid for copy and paste.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Oracle connector

How would you describe this change to a non-technical end user or system administrator?

Fix invalid syntax in code snippet for catalog properties file.

Related issues, pull requests, and links

  • none

Documentation

(✅ ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ✅ ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@mosabua mosabua requested review from jhlodin and hashhar March 2, 2022 16:55
@github-actions github-actions bot added the docs label Mar 2, 2022
@cla-bot cla-bot bot added the cla-signed label Mar 2, 2022
@mosabua mosabua changed the title Remove invalid, redundant comment Change to valid comment in code snippet Mar 2, 2022
@martint martint merged commit 5a24dd9 into trinodb:master Mar 2, 2022
@github-actions github-actions bot added this to the 372 milestone Mar 2, 2022
@mosabua mosabua deleted the oracle-comment branch March 3, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants