Test translation of view with namesake column aliases which are differing in case #11240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Mar 1, 2022
...ing/trino-product-tests/src/main/java/io/trino/tests/product/hive/AbstractTestHiveViews.java
Show resolved
Hide resolved
| @@ -664,6 +664,28 @@ public void testViewReferencingHiveAndIcebergTables() | |||
| onHive().executeQuery("DROP TABLE default.view_iceberg_table"); | |||
| } | |||
|
|
|||
| @Test(groups = HIVE_VIEWS) | |||
| public void testNamesakeColumnsShouldGetUniqueIdentifiersDuringTheTranslationToAvoidAmbiguity() | |||
There was a problem hiding this comment.
testViewWithColumnAliasesDifferingInCase ?
findinpath
force-pushed
the
coral-hive-case-insensitive-handling-for-namesake-column-names
branch
from
b72b30e to
bd4a197
Compare
findinpath
force-pushed
the
coral-hive-case-insensitive-handling-for-namesake-column-names
branch
from
bd4a197 to
e9c6da3
Compare
|
Rebased on |
|
Can you please rename commit and PR similar to #11240 (comment) ? |
findinpath
changed the title
…ring in case In the translation of Hive views with Coral, when joining tables that have the namesake column names, irrespective of their case, make sure that the resulting relation is using names of the columns which are unique in order to avoid the situation where the SQL statement created contains ambiguous column names.
findinpath
force-pushed
the
coral-hive-case-insensitive-handling-for-namesake-column-names
branch
from
e9c6da3 to
ab617d1
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the translation of Hive views with Coral,
when joining tables that have the namesake column names,
irrespective of their case, make sure that the resulting
relation is using names of the columns which are
unique in order to avoid the situation where the
SQL statement created contains ambiguous column names.
Test
This change applies to Hive and specifically to the translation of Hive views.
Hive translation of views that joined tables having namesake column names spelled in different cases failed before because of ambiguous column name reference. The upgrade of the Coral library contains a fix for such usecases.
Related issues, pull requests, and links
Coral PR: linkedin/coral#234
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: