Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump antlr to 4.9.3 #11221

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Bump antlr to 4.9.3 #11221

merged 1 commit into from
Feb 28, 2022

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Feb 28, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Housekeeping

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Core engine

How would you describe this change to a non-technical end user or system administrator?

Library upgrade.

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 28, 2022
@wendigo wendigo requested a review from findepi February 28, 2022 15:25
@findepi findepi requested a review from martint February 28, 2022 16:05
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wait until jdbi/jdbi#2006 is merged and released, otherwise the mismatch will cause log spam. See jdbi/jdbi#1793

@electrum
Copy link
Member

It seems ANTLR only warns if the first two digits don't match, so this should be fine.

@electrum electrum merged commit 3010518 into trinodb:master Feb 28, 2022
@github-actions github-actions bot added this to the 372 milestone Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants