Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge AbstractTestDistributedQueries into BaseConnectorTest #11213

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Merge AbstractTestDistributedQueries into BaseConnectorTest #11213

merged 2 commits into from
Feb 28, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Feb 28, 2022

Description

Merge AbstractTestDistributedQueries into BaseConnectorTest

# master
grep "void test" testing/trino-testing/src/main/java/io/trino/testing/AbstractTestDistributedQueries.java  | wc -l
39

grep "void test" testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java  | wc -l
48

# after
grep "void test" testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java  | wc -l
83

The diff (-4) comes from testView, testAddColumn, testDropColumn, testRenameColumn were overridden in BaseConnectorTest

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Feb 28, 2022
findepi
findepi approved these changes Feb 28, 2022
View reviewed changes
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
@@ -165,7 +185,6 @@ protected final boolean supportsCommentOnTable()
* @deprecated Use {@link #hasBehavior(TestingConnectorBehavior)} instead.
*/
@Deprecated
@Override
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These deprecated methods should be removed (inlined) now.

@ebyhr
Copy link
Member Author

ebyhr commented Feb 28, 2022

CI #11220

@ebyhr ebyhr merged commit c53ee94 into trinodb:master Feb 28, 2022
@ebyhr ebyhr deleted the ebi/test-bct branch February 28, 2022 13:30
@github-actions github-actions bot added this to the 372 milestone Feb 28, 2022
@mosabua mosabua mentioned this pull request Feb 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
372
Development

Successfully merging this pull request may close these issues.
2 participants
@ebyhr @findepi