Add table comments interface in base JDBC and implement in MySQL #11211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ebyhr
force-pushed
the
ebi/jdbc-comment-table
branch
from
43db833 to
b1ae7c4
Compare
findepi
previously requested changes
Feb 28, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/DefaultJdbcMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcTableHandle.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcTableHandle.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/jdbc-comment-table
branch
from
b1ae7c4 to
30751a1
Compare
findepi
reviewed
Mar 1, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/jdbc-comment-table
branch
from
30751a1 to
f57fdef
Compare
findepi
reviewed
Mar 2, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/CachingJdbcClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/CachingJdbcClient.java
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcClient.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/jdbc-comment-table
branch
6 times, most recently
from
156170c to
f5dac2c
Compare
hashhar
reviewed
Mar 14, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcTableHandle.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/jdbc-comment-table
branch
from
f5dac2c to
c95e0f4
Compare
hashhar
reviewed
Mar 15, 2022
There was a problem hiding this comment.
Should we also test that creating a table without comments indeed doesn't return any comments in the info schema and SHOW CREATE output?
Existing test in BaseConnectorTest#testCommentTable only tests setting comments and creating table with comments. Note that testShowCreateTable doesn't test this since it checks against TPCH tables which may be created without using Trino during test setup.
LGTM % this comment
ebyhr
force-pushed
the
ebi/jdbc-comment-table
branch
from
c95e0f4 to
c116960
Compare
hashhar
approved these changes
Mar 15, 2022
ebyhr
force-pushed
the
ebi/jdbc-comment-table
branch
from
c116960 to
e0f3681
Compare
|
@hashhar I modified |
hashhar
reviewed
Mar 16, 2022
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Show resolved
Hide resolved
hashhar
approved these changes
Mar 16, 2022
ebyhr
force-pushed
the
ebi/jdbc-comment-table
branch
from
e0f3681 to
85a7f51
Compare
|
Rebased on upstream to resolve conflicts. |
ebyhr
force-pushed
the
ebi/jdbc-comment-table
branch
from
85a7f51 to
4a71c31
Compare
ebyhr
force-pushed
the
ebi/jdbc-comment-table
branch
from
4a71c31 to
4455c03
Compare
ebyhr
force-pushed
the
ebi/jdbc-comment-table
branch
from
4455c03 to
3e06544
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add table comments interface in base JDBC and implement in MySQL
Fixes #2517
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: