Rename hash partition configuration property #11204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove "initial" from the name. It could be understood as if execution is adaptive. Presumably, "initial" meant that the value can be overridden by a session property. If that's the case, this is not necessary & not how we name properties. The new property name is aligned with session property (`hash_partition_count`).
In order to maintain class immutability.
findepi
force-pushed
the
findepi/rename-hash-partition-configuration-property-df456b
branch
from
fd7bff9 to
c0bc23d
Compare
|
previous CI #10846 |
sopel39
approved these changes
Feb 28, 2022
findepi
deleted the
findepi/rename-hash-partition-configuration-property-df456b
branch
|
Filed #11256 and will implement |
This was referenced Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "initial" from the name. It could be understood as if execution
is adaptive. Presumably, "initial" meant that the value can be
overridden by a session property. If that's the case, this is not
necessary & not how we name properties.
The new property name is aligned with session property
(
hash_partition_count).The property is not documented, so no docs changed needed.