Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document prepared statement compression properties. #11189

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Feb 24, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation only.

How would you describe this change to a non-technical end user or system administrator?

Add documentation for optional properties.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@mosabua mosabua requested a review from findepi February 24, 2022 23:33
@mosabua mosabua force-pushed the prep-statement-header branch from 3776c06 to e693d09 Compare February 24, 2022 23:46
@cla-bot cla-bot bot added the cla-signed label Feb 24, 2022
@mosabua mosabua requested a review from Ordinant February 24, 2022 23:46
@mosabua mosabua force-pushed the prep-statement-header branch 2 times, most recently from 4f58ea9 to 0aa4158 Compare February 24, 2022 23:49
@mosabua mosabua added the docs label Feb 24, 2022
Copy link
Member

@Ordinant Ordinant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions.

docs/src/main/sphinx/admin/properties-general.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/admin/properties-general.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/admin/properties-general.rst Outdated Show resolved Hide resolved
@mosabua mosabua force-pushed the prep-statement-header branch from 0aa4158 to 3cb1bf5 Compare February 25, 2022 00:11
@mosabua mosabua force-pushed the prep-statement-header branch from 3cb1bf5 to f02b9f8 Compare February 25, 2022 16:37
@mosabua mosabua force-pushed the prep-statement-header branch from f02b9f8 to 2bd0182 Compare February 25, 2022 17:00
@findepi findepi merged commit 0e340de into trinodb:master Feb 25, 2022
@github-actions github-actions bot added this to the 372 milestone Feb 26, 2022
@mosabua mosabua deleted the prep-statement-header branch March 2, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Document prepared statement compression properties
3 participants