Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to guess field types in MongoDB #11178

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Feb 24, 2022

Description

Add test to guess field types in MongoDB and document the mapping.

Related issues, pull requests, and links

Documentation

(x) Sufficient documentation is included in this PR.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Feb 24, 2022
@ebyhr ebyhr requested a review from hashhar February 24, 2022 05:07
@ebyhr ebyhr requested a review from hashhar February 24, 2022 08:40
@github-actions github-actions bot added the docs label Feb 24, 2022
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % Manfred's comment

Additionally, improve the sentence how to handle wrong table
definitions.
@ebyhr ebyhr force-pushed the ebi/mongodb-guess-fields branch from a1bd9f5 to 131976c Compare February 24, 2022 09:07
@ebyhr ebyhr merged commit 5abd6f5 into trinodb:master Feb 24, 2022
@ebyhr ebyhr deleted the ebi/mongodb-guess-fields branch February 24, 2022 23:24
@github-actions github-actions bot added this to the 372 milestone Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add test to guess field types in MongoDB Document type mapping in MongoDB documentation
3 participants