Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support guessing BinData type as varbinary in MongoDB #11122

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Feb 21, 2022

Description

Support guessing BinData type as varbinary in MongoDB

Documentation

(x) Documentation issue #11121 is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# MongoDB
* Support guessing MongoDB `bindata` type as Trino `varbinary` type . ({issue}`11122`)

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Discussed offline regarding the test using ("invalid/unexpected") DBRefs - it can be tackled separately.

@ebyhr ebyhr merged commit d72b25e into trinodb:master Feb 23, 2022
@ebyhr ebyhr deleted the ebi/mongodb-dbref-types branch February 23, 2022 00:52
@ebyhr ebyhr mentioned this pull request Feb 23, 2022
@github-actions github-actions bot added this to the 372 milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants