Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Kafka to use BaseConnectorTest #11114

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Feb 21, 2022

Description

Migrate Kafka to use BaseConnectorTest

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

This is a preparatory commit for migrating to BaseConnectorTest.
@cla-bot cla-bot bot added the cla-signed label Feb 21, 2022
@ebyhr ebyhr added the maintenance Project maintenance task label Feb 21, 2022
@ebyhr ebyhr requested a review from hashhar February 21, 2022 23:20
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits about comments

@ebyhr ebyhr force-pushed the ebi/kafka-migrate-test branch from cfab463 to d2b36b5 Compare February 22, 2022 07:33
@ebyhr
Copy link
Member Author

ebyhr commented Feb 22, 2022

CI #10197

@ebyhr ebyhr merged commit dd0b5dc into trinodb:master Feb 23, 2022
@ebyhr ebyhr deleted the ebi/kafka-migrate-test branch February 23, 2022 00:27
@github-actions github-actions bot added this to the 372 milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed maintenance Project maintenance task
Development

Successfully merging this pull request may close these issues.

Migrate Kafka tests to use BaseConnectorTest
2 participants