Migrate to BaseConnectorTest in BigQuery #11108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/bigquery-connector-test
branch
from
eb34826 to
c733190
Compare
ebyhr
force-pushed
the
ebi/bigquery-connector-test
branch
from
c733190 to
30dbed8
Compare
An empty table is sufficient to verify the connector behavior.
ebyhr
force-pushed
the
ebi/bigquery-connector-test
branch
3 times, most recently
from
876e5c4 to
136c3c9
Compare
hashhar
reviewed
Feb 25, 2022
| @@ -771,7 +771,7 @@ public void testDeleteWithVarcharPredicate() | |||
| protected void skipTestUnlessSupportsDeletes() | |||
| { | |||
| skipTestUnless(supportsCreateTable()); | |||
| try (TestTable table = new TestTable(getQueryRunner()::execute, "test_supports_delete", "(col varchar(1))", ImmutableList.of("'a'", "'A'"))) { | |||
| try (TestTable table = new TestTable(getQueryRunner()::execute, "test_supports_delete", "(col varchar(1))")) { | |||
There was a problem hiding this comment.
Thank you. I was testing for CREATE TABLE but performing CTAS in the test.
testing/trino-testing/src/main/java/io/trino/testing/AbstractTestDistributedQueries.java
Outdated
Show resolved
Hide resolved
| @Override | ||
| public void testRenameTable() | ||
| { | ||
| // Use CREATE TABLE instead of CREATE TABLE AS statement |
There was a problem hiding this comment.
Can we fix this in base test? It seems we don't need CTAS to test rename table either?
There was a problem hiding this comment.
We could do it, but I hesitated to change in this PR because the test contains assertion for values.
- Allow overriding the table definition - Set table properties in Kudu to provide table definition
This is a preparatory commit for migrating to BaseConnectorTest.
ebyhr
force-pushed
the
ebi/bigquery-connector-test
branch
from
136c3c9 to
d6b0159
Compare
hashhar
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate to BaseConnectorTest in BigQuery
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.